Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1842)

Issue 29573947: Noissue - Restructure Build-and-Release-Tools and Sitescripts modules

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 2 days ago by Sebastian Noack
Modified:
14 hours, 5 minutes ago
CC:
saroyanm
Visibility:
Public.

Description

Noissue - Restructure Build-and-Release-Tools and Sitescripts modules

Patch Set 1 #

Total comments: 11

Patch Set 2 : Named module "Automation" #

Patch Set 3 : Added description #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M pages/modules.html View 1 2 5 chunks +17 lines, -17 lines 3 comments Download

Messages

Total messages: 29
Sebastian Noack
This suggestion is by no means final. But what would you think if we'd move ...
1 week, 2 days ago (2017-10-12 03:20:36 UTC) #1
kzar
I think this is a good idea overall FWIW. https://codereview.adblockplus.org/29573947/diff/29573948/pages/modules.html File pages/modules.html (left): https://codereview.adblockplus.org/29573947/diff/29573948/pages/modules.html#oldcode149 pages/modules.html:149: ...
1 week, 1 day ago (2017-10-12 09:10:48 UTC) #2
Vasily Kuznetsov
I like the idea of making the module structure closer to the project team structure ...
1 week, 1 day ago (2017-10-12 12:14:35 UTC) #3
tlucas
To be honest - i wouldn't mind / reject being a module owner peer, but ...
1 week, 1 day ago (2017-10-12 12:34:01 UTC) #4
kzar
On 2017/10/12 12:34:01, tlucas wrote: > To be honest - i wouldn't mind / reject ...
1 week, 1 day ago (2017-10-12 13:17:05 UTC) #5
01687286395a
On 2017/10/12 09:10:48, kzar wrote: > I think this is a good idea overall FWIW. ...
1 week, 1 day ago (2017-10-12 15:20:08 UTC) #6
Sebastian Noack
On 2017/10/12 12:14:35, Vasily Kuznetsov wrote: > I like the idea of making the module ...
1 week, 1 day ago (2017-10-12 22:28:10 UTC) #7
Vasily Kuznetsov
TLDR: LGTM On 2017/10/12 22:28:10, Sebastian Noack wrote: > On 2017/10/12 12:14:35, Vasily Kuznetsov wrote: ...
1 week ago (2017-10-13 09:44:02 UTC) #8
kzar
LGTM
1 week ago (2017-10-13 12:31:08 UTC) #9
tlucas
https://codereview.adblockplus.org/29573947/diff/29573948/pages/modules.html File pages/modules.html (right): https://codereview.adblockplus.org/29573947/diff/29573948/pages/modules.html#newcode141 pages/modules.html:141: <td>Tooling</td> On 2017/10/12 09:10:48, kzar wrote: > On 2017/10/12 ...
1 week ago (2017-10-13 16:35:42 UTC) #10
kzar
On 2017/10/13 16:35:42, tlucas wrote: > https://codereview.adblockplus.org/29573947/diff/29573948/pages/modules.html > File pages/modules.html (right): > > https://codereview.adblockplus.org/29573947/diff/29573948/pages/modules.html#newcode141 > ...
1 week ago (2017-10-13 19:22:38 UTC) #11
Sebastian Noack
Nice, it seems we are all set. I promoted Felix to reviewer, to make him ...
1 week ago (2017-10-13 20:01:56 UTC) #12
Vasily Kuznetsov
On 2017/10/13 20:01:56, Sebastian Noack wrote: > Nice, it seems we are all set. > ...
6 days, 17 hours ago (2017-10-14 11:34:47 UTC) #13
Sebastian Noack
On 2017/10/14 11:34:47, Vasily Kuznetsov wrote: > If we rename the module here, should the ...
5 days, 23 hours ago (2017-10-15 05:34:26 UTC) #14
Felix Dahlke
I see n distinct changes here: 1. Rename the "Build and Release Tools" module to ...
3 days, 17 hours ago (2017-10-17 11:23:36 UTC) #15
juliandoucette
Do we intend to translate this page in the future?
3 days, 17 hours ago (2017-10-17 11:26:57 UTC) #16
Felix Dahlke
On 2017/10/17 11:26:57, juliandoucette wrote: > Do we intend to translate this page in the ...
3 days, 17 hours ago (2017-10-17 11:42:39 UTC) #17
kzar
On 2017/10/17 11:23:36, Felix Dahlke wrote: > ... But I'm curious to hear what others ...
3 days, 15 hours ago (2017-10-17 13:17:53 UTC) #18
Vasily Kuznetsov
On 2017/10/17 11:23:36, Felix Dahlke wrote: > I see n distinct changes here: > > ...
3 days, 14 hours ago (2017-10-17 14:35:08 UTC) #19
Sebastian Noack
I'm not sure how much more generic the module would be if we go ahead ...
3 days, 7 hours ago (2017-10-17 20:52:16 UTC) #20
Felix Dahlke
On 2017/10/17 20:52:16, Sebastian Noack wrote: > I'm not sure how much more generic the ...
1 day, 20 hours ago (2017-10-19 08:11:14 UTC) #21
Felix Dahlke
I'm off tomorrow and next week and I don't want to block this, so I've ...
1 day, 10 hours ago (2017-10-19 18:43:21 UTC) #22
Sebastian Noack
Sounds good to me. In other words, as I said before, the rules enforced by ...
1 day, 9 hours ago (2017-10-19 19:06:58 UTC) #23
tlucas
On 2017/10/19 19:06:58, Sebastian Noack wrote: > Sounds good to me. In other words, as ...
1 day, 6 hours ago (2017-10-19 22:21:43 UTC) #24
Sebastian Noack
Well, as per Felix comment above (and the discussion I had with him on IRC), ...
1 day, 3 hours ago (2017-10-20 01:19:46 UTC) #25
Sebastian Noack
Added the description. https://codereview.adblockplus.org/29573947/diff/29583642/pages/modules.html File pages/modules.html (right): https://codereview.adblockplus.org/29573947/diff/29583642/pages/modules.html#newcode68 pages/modules.html:68: <td>{{module-ui-description The User Interface of the ...
1 day, 2 hours ago (2017-10-20 01:53:38 UTC) #26
kzar
LGTM https://codereview.adblockplus.org/29573947/diff/29583642/pages/modules.html File pages/modules.html (right): https://codereview.adblockplus.org/29573947/diff/29583642/pages/modules.html#newcode68 pages/modules.html:68: <td>{{module-ui-description The User Interface of the Adblock Plus ...
17 hours, 1 minute ago (2017-10-20 11:48:14 UTC) #27
Thomas Greiner
LGTM https://codereview.adblockplus.org/29573947/diff/29583642/pages/modules.html File pages/modules.html (right): https://codereview.adblockplus.org/29573947/diff/29583642/pages/modules.html#newcode68 pages/modules.html:68: <td>{{module-ui-description The User Interface of the Adblock Plus ...
14 hours, 11 minutes ago (2017-10-20 14:38:13 UTC) #28
juliandoucette
14 hours, 5 minutes ago (2017-10-20 14:44:26 UTC) #29
HTML change LGTM. I'll stay out of the other discussions.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5