Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(107)

Issue 29574577: Issue 5856 - Pass --no-package-lock argument to npm install (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by kzar
Modified:
2 years, 4 months ago
Reviewers:
Sebastian Noack, tlucas
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 5856 - Pass --no-package-lock argument to npm install

Patch Set 1 #

Total comments: 4

Patch Set 2 : Don't ignore the package-lock.json file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ensure_dependencies.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6
kzar
Patch Set 1 https://codereview.adblockplus.org/29574577/diff/29574578/.hgignore File .hgignore (left): https://codereview.adblockplus.org/29574577/diff/29574578/.hgignore#oldcode5 .hgignore:5: .tox I noticed this entry wasn't ...
2 years, 4 months ago (2017-10-12 11:51:08 UTC) #1
tlucas
https://codereview.adblockplus.org/29574577/diff/29574578/.gitignore File .gitignore (right): https://codereview.adblockplus.org/29574577/diff/29574578/.gitignore#newcode4 .gitignore:4: /package-lock.json I don't think this should be necessary - ...
2 years, 4 months ago (2017-10-12 12:01:59 UTC) #2
tlucas
https://codereview.adblockplus.org/29574577/diff/29574578/.gitignore File .gitignore (right): https://codereview.adblockplus.org/29574577/diff/29574578/.gitignore#newcode4 .gitignore:4: /package-lock.json On 2017/10/12 12:01:59, tlucas wrote: > I don't ...
2 years, 4 months ago (2017-10-12 12:28:13 UTC) #3
kzar
Patch Set 2 : Don't ignore the package-lock.json file https://codereview.adblockplus.org/29574577/diff/29574578/.gitignore File .gitignore (right): https://codereview.adblockplus.org/29574577/diff/29574578/.gitignore#newcode4 .gitignore:4: ...
2 years, 4 months ago (2017-10-12 13:20:12 UTC) #4
tlucas
let's see what the other think :) LGTM though
2 years, 4 months ago (2017-10-12 13:21:20 UTC) #5
Sebastian Noack
2 years, 4 months ago (2017-10-12 14:53:40 UTC) #6
Message was sent while issue was closed.
LGTM!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5