Issue 5856 - Pass --no-package-lock argument to npm install

.gitignore

Index: .gitignore
diff --git a/.gitignore b/.gitignore
index 4090c27fcf0de9c3721a8aa7f68fc5447ba61d52..7bd59148c270b9bf44719abee7d6ee7b44722970 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,4 @@
 *.pyc
 *.pyo
 /.tox
+/package-lock.json

[tlucas, 2017/10/12 12:01:59]

I don't think this should be necessary - after all, we won't create any
package-lock.json in the future...

For the time being, since there are now untracked package-lock.json files due to
https://hg.adblockplus.org/buildtools/rev/e9059b211107 , i'd rather delete them
manually instead of ignoring them (Maybe with an integration note in #5856)

IIRC, this only happend in adblockpluschrome and adblockplusui - so one would
only have to manually delete the untracked files from

./adblockplusui/buildtools
./buildtools

(No guarantee here though)


... what do you think?

[tlucas, 2017/10/12 12:28:13]

I just noticed your explanation in the ticket, i.e. why you wanted to add this.
IMHO it should never be necessary to manually run 'npm install' (or at least we
should make sure that there is no necessity to ever do so).

On the other hand, if the user runs 'npm install' and creates a
package-lock.json, the notification about a new unstaged file could possibly
prevent an existing package-lock.json to somehow (not sure in what way though,
but i got somehow cautious about this yesterday) mess up an npm installation. If
neither git, nor hg warned about this new file, one could easily overlook
this...

[kzar, 2017/10/12 13:20:12]

Yea good point, I think I agree. Done.