Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(764)

Issue 29574665: Issue 5159 - Expose collapse property for BlockingFilter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by hub
Modified:
3 weeks, 1 day ago
Reviewers:
sergei, Wladimir Palant
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 5159 - Expose collapse property for BlockingFilter

Patch Set 1 #

Total comments: 5

Patch Set 2 : Added test for collapse #

Total comments: 2

Patch Set 3 : Feedback applied. #

Patch Set 4 : added test for the property #

Total comments: 2

Patch Set 5 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -14 lines) Patch
M compiled/bindings/main.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M compiled/filter/BlockingFilter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M compiled/filter/RegExpFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M compiled/filter/RegExpFilter.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/filterClasses.js View 1 2 3 4 3 chunks +18 lines, -10 lines 0 comments Download

Messages

Total messages: 11
hub
2 months ago (2017-10-12 18:41:44 UTC) #1
sergei
LGTM https://codereview.adblockplus.org/29574665/diff/29574666/compiled/bindings/main.cpp File compiled/bindings/main.cpp (right): https://codereview.adblockplus.org/29574665/diff/29574666/compiled/bindings/main.cpp#newcode78 compiled/bindings/main.cpp:78: .property("collapse", &BlockingFilter::GetCollapse); JIC, it would be better to ...
2 months ago (2017-10-13 07:52:15 UTC) #2
Wladimir Palant
Yes, this definitely needs tests.
2 months ago (2017-10-13 09:28:24 UTC) #3
hub
test that collapse is true on blocking filter, and undefined on another filter. https://codereview.adblockplus.org/29574665/diff/29574666/compiled/bindings/main.cpp File ...
2 months ago (2017-10-13 15:41:03 UTC) #4
sergei
https://codereview.adblockplus.org/29574665/diff/29574666/compiled/bindings/main.cpp File compiled/bindings/main.cpp (right): https://codereview.adblockplus.org/29574665/diff/29574666/compiled/bindings/main.cpp#newcode78 compiled/bindings/main.cpp:78: .property("collapse", &BlockingFilter::GetCollapse); On 2017/10/13 15:41:03, hub wrote: > On ...
3 weeks, 2 days ago (2017-11-21 11:24:04 UTC) #5
hub
https://codereview.adblockplus.org/29574665/diff/29575641/compiled/filter/RegExpFilter.cpp File compiled/filter/RegExpFilter.cpp (right): https://codereview.adblockplus.org/29574665/diff/29575641/compiled/filter/RegExpFilter.cpp#newcode221 compiled/filter/RegExpFilter.cpp:221: data.mCollapse = reverse ? false : true; On 2017/11/21 ...
3 weeks, 2 days ago (2017-11-21 15:15:20 UTC) #6
hub
https://codereview.adblockplus.org/29574665/diff/29574666/compiled/bindings/main.cpp File compiled/bindings/main.cpp (right): https://codereview.adblockplus.org/29574665/diff/29574666/compiled/bindings/main.cpp#newcode78 compiled/bindings/main.cpp:78: .property("collapse", &BlockingFilter::GetCollapse); On 2017/11/21 11:24:03, sergei wrote: > On ...
3 weeks, 2 days ago (2017-11-21 15:18:19 UTC) #7
hub
https://codereview.adblockplus.org/29574665/diff/29574666/compiled/bindings/main.cpp File compiled/bindings/main.cpp (right): https://codereview.adblockplus.org/29574665/diff/29574666/compiled/bindings/main.cpp#newcode78 compiled/bindings/main.cpp:78: .property("collapse", &BlockingFilter::GetCollapse); On 2017/11/21 15:18:19, hub wrote: > On ...
3 weeks, 2 days ago (2017-11-21 15:37:59 UTC) #8
sergei
https://codereview.adblockplus.org/29574665/diff/29613783/test/filterClasses.js File test/filterClasses.js (right): https://codereview.adblockplus.org/29574665/diff/29613783/test/filterClasses.js#newcode106 test/filterClasses.js:106: if (filter instanceof BlockingFilter) What about checking that `filter.collapse` ...
3 weeks, 2 days ago (2017-11-21 16:17:01 UTC) #9
hub
https://codereview.adblockplus.org/29574665/diff/29613783/test/filterClasses.js File test/filterClasses.js (right): https://codereview.adblockplus.org/29574665/diff/29613783/test/filterClasses.js#newcode106 test/filterClasses.js:106: if (filter instanceof BlockingFilter) On 2017/11/21 16:17:01, sergei wrote: ...
3 weeks, 1 day ago (2017-11-21 17:42:47 UTC) #10
sergei
3 weeks, 1 day ago (2017-11-21 19:20:52 UTC) #11
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5