Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29576555: Noissue - Moved new apb.org #content padding to index*.css (Closed)

Created:
Oct. 14, 2017, 1:06 p.m. by juliandoucette
Modified:
Oct. 17, 2017, 1:22 p.m.
Reviewers:
ire
Base URL:
https://bitbucket.org/adblockplus/adblockplus.org
Visibility:
Public.

Description

Noissue - Moved new apb.org #content padding to index*.css

Patch Set 1 #

Patch Set 2 : Fixed desktop/mobile mix-up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M static/css/index.css View 1 1 chunk +5 lines, -0 lines 0 comments Download
M static/css/index-mobile.css View 1 1 chunk +1 line, -0 lines 0 comments Download
M static/css/main.css View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 7
juliandoucette
Oct. 14, 2017, 1:06 p.m. (2017-10-14 13:06:33 UTC) #1
juliandoucette
Because #content h1 margin is enough.
Oct. 14, 2017, 1:07 p.m. (2017-10-14 13:07:17 UTC) #2
ire
Two things: 1. I think you switched around the sizes. Previously, the padding-top was 2.5em ...
Oct. 16, 2017, 7:36 a.m. (2017-10-16 07:36:03 UTC) #3
juliandoucette
On 2017/10/16 07:36:03, ire wrote: > Two things: > > 1. I think you switched ...
Oct. 16, 2017, 12:26 p.m. (2017-10-16 12:26:04 UTC) #4
juliandoucette
Uploaded new PatchSet. I'll address the deployments page separately.
Oct. 16, 2017, 12:40 p.m. (2017-10-16 12:40:36 UTC) #5
ire
On 2017/10/16 12:40:36, juliandoucette wrote: > Uploaded new PatchSet. > > I'll address the deployments ...
Oct. 16, 2017, 2:20 p.m. (2017-10-16 14:20:37 UTC) #6
juliandoucette
Oct. 17, 2017, 1:22 p.m. (2017-10-17 13:22:09 UTC) #7

Powered by Google App Engine
This is Rietveld