Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29577555: Issue 5080 - Start using our new webpack build system (Closed)

Created:
Oct. 15, 2017, 1:12 p.m. by kzar
Modified:
Oct. 18, 2017, 11:08 a.m.
Reviewers:
Sebastian Noack
CC:
tlucas, Manish Jethani
Visibility:
Public.

Description

Issue 5080 - Start using our new webpack build system Based upon Manish's browser namespace changes here https://codereview.adblockplus.org/29570614/

Patch Set 1 #

Patch Set 2 : Update buildtools dependency to include typo fix #

Total comments: 2

Patch Set 3 : Export everything from include.preload.js at once #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -49 lines) Patch
M .eslintrc.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M composer.postload.js View 1 chunk +3 lines, -2 lines 0 comments Download
M dependencies View 1 1 chunk +1 line, -1 line 0 comments Download
M include.preload.js View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M metadata.chrome View 4 chunks +10 lines, -45 lines 0 comments Download
M metadata.gecko View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
kzar
Patch Set 1 There's probably more that the switch to webpack allows us to tidy ...
Oct. 15, 2017, 1:19 p.m. (2017-10-15 13:19:26 UTC) #1
kzar
Patch Set 2 : Update buildtools dependency to include typo fix
Oct. 15, 2017, 2:02 p.m. (2017-10-15 14:02:26 UTC) #2
Manish Jethani
(Keeping myself in CC) https://codereview.adblockplus.org/29577555/diff/29577562/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29577555/diff/29577562/include.preload.js#newcode527 include.preload.js:527: exports.checkCollapse = checkCollapse; In Node.js ...
Oct. 15, 2017, 9:22 p.m. (2017-10-15 21:22:05 UTC) #3
kzar
Patch Set 3 : Export everything from include.preload.js at once https://codereview.adblockplus.org/29577555/diff/29577562/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29577555/diff/29577562/include.preload.js#newcode527 ...
Oct. 16, 2017, 10 a.m. (2017-10-16 10:00:07 UTC) #4
Sebastian Noack
Oct. 17, 2017, 9:49 p.m. (2017-10-17 21:49:12 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld