Issue 5080 - Start using our new webpack build system

Issue 5080 - Start using our new webpack build system

Based upon Manish's browser namespace changes here https://codereview.adblockplus.org/29570614/

[kzar, 2017-10-15 13:19:26]

Patch Set 1

There's probably more that the switch to webpack allows us to tidy up, I'm open
to suggestions there. Perhaps we should make them separately after we've
switched over though, but I guess it depends on how sweeping they are.

[kzar, 2017-10-15 14:02:26]

Patch Set 2 : Update buildtools dependency to include typo fix

[Manish Jethani, 2017-10-15 21:22:05]

(Keeping myself in CC)

https://codereview.adblockplus.org/29577555/diff/29577562/include.preload.js
File include.preload.js (right):

https://codereview.adblockplus.org/29577555/diff/29577562/include.preload.js#...
include.preload.js:527: exports.checkCollapse = checkCollapse;
In Node.js you can usually do:

  module.exports = {
    checkCollapse,
    elemhide,
    typeMap,
    getURLsFromElement
  };

Which happens to look a lot neater, in my opinion. I'm not sure this can be done
here, but worth a shot.

[kzar, 2017-10-16 10:00:07]

Patch Set 3 : Export everything from include.preload.js at once

https://codereview.adblockplus.org/29577555/diff/29577562/include.preload.js
File include.preload.js (right):

https://codereview.adblockplus.org/29577555/diff/29577562/include.preload.js#...
include.preload.js:527: exports.checkCollapse = checkCollapse;
On 2017/10/15 21:22:05, Manish Jethani wrote:
> In Node.js you can usually do:
> 
>   module.exports = {
>     checkCollapse,
>     elemhide,
>     typeMap,
>     getURLsFromElement
>   };
> 
> Which happens to look a lot neater, in my opinion. I'm not sure this can be
done
> here, but worth a shot.

Done.

[Sebastian Noack, 2017-10-17 21:49:12]

LGTM