Unified Diff: desktop-options.html
Issue 29578574:
Issue 5632 - Use checkboxes for toggling acceptable ads (Closed)
Patch Set: Addressed Ire's comments
Created Oct. 19, 2017, 8:40 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
desktop-options.js » ('j')
|
desktop-options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: desktop-options.html |
| =================================================================== |
| --- a/desktop-options.html |
| +++ b/desktop-options.html |
| @@ -97,22 +97,24 @@ |
| <p class="i18n_options_acceptableAds_description"></p> |
| </header> |
| <form id="acceptable-ads"> |
| - <div> |
| - <input data-action="switch-acceptable-ads" type="radio" name="acceptable-ads" value="ads"> |
| - <label class="i18n_options_acceptableAds_ads_label"></label> |
| - <p id="enable-aa-description" class="i18n_options_acceptableAds_ads_description_1"></p> |
| - <p class="i18n_options_acceptableAds_ads_description_2"></p> |
| - </div> |
| - <div> |
| - <input data-action="switch-acceptable-ads" type="radio" name="acceptable-ads" value="privacy"> |
| - <label class="i18n_options_acceptableAds_privacy_label"></label> |
| - <p class="i18n_options_acceptableAds_privacy_description"></p> |
| - <p id="dnt" class="i18n_options_acceptableAds_dnt_notification"></p> |
| - </div> |
| - <div> |
| - <input data-action="switch-acceptable-ads" type="radio" name="acceptable-ads" value="none"> |
| - <label class="i18n_options_acceptableAds_none_label"></label> |
| - </div> |
| + <ul> |
| + <li> |
| + <button id="acceptable-ads-allow" data-action="switch-acceptable-ads" type="button" role="checkbox" name="acceptable-ads" value="ads"></button> |
| + <label for="acceptable-ads-allow" class="i18n_options_acceptableAds_ads_label"></label> |
| + <p id="enable-acceptable-ads-description" class="i18n_options_acceptableAds_ads_description_1"></p> |
| + <p class="i18n_options_acceptableAds_ads_description_2"></p> |
| + </li> |
| + <ul> |
| + <li> |
| + <button id="acceptable-ads-privacy-allow" data-action="switch-acceptable-ads" type="button" role="checkbox" name="acceptable-ads" value="privacy"></button> |
| + <label for="acceptable-ads-privacy-allow" class="i18n_options_acceptableAds_privacy_label"></label> |
| + <a id="enable-acceptable-ads-privacy-description"> |
| + <p class="i18n_options_acceptableAds_privacy_description"></p> |
| + </a> |
|
Thomas Greiner
2017/10/20 15:35:03
Detail: We don't want to hyperlink the entire bloc
saroyanm
2017/10/20 16:42:06
Done, I'll fix wording and section in separate iss
|
| + <p id="dnt" class="i18n_options_acceptableAds_dnt_notification"></p> |
| + </li> |
| + </ul> |
| + </ul> |
| </form> |
| </section> |
| <section class="cols"> |
« no previous file with comments
|
« no previous file
|
desktop-options.js » ('j')
|
desktop-options.js » ('J')
