Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29581789: Noissue - Hotfixed new apb.org deployments page (Closed)

Created:
Oct. 17, 2017, 1:20 p.m. by juliandoucette
Modified:
Oct. 18, 2017, 12:31 p.m.
Reviewers:
ire
Base URL:
https://bitbucket.org/adblockplus/adblockplus.org
Visibility:
Public.

Description

I think that we should consider refactoring this page separately.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M static/css/lsd.css View 1 chunk +15 lines, -3 lines 2 comments Download

Messages

Total messages: 3
juliandoucette
Oct. 17, 2017, 1:20 p.m. (2017-10-17 13:20:07 UTC) #1
ire
> I think that we should consider refactoring this page separately. I agree. LGTM https://codereview.adblockplus.org/29581789/diff/29581790/static/css/lsd.css ...
Oct. 18, 2017, 8:07 a.m. (2017-10-18 08:07:54 UTC) #2
juliandoucette
Oct. 18, 2017, 12:30 p.m. (2017-10-18 12:30:57 UTC) #3
https://bitbucket.org/adblockplus/adblockplus.org/commits/c74c20e843913d10d0a...

https://codereview.adblockplus.org/29581789/diff/29581790/static/css/lsd.css
File static/css/lsd.css (right):

https://codereview.adblockplus.org/29581789/diff/29581790/static/css/lsd.css#...
static/css/lsd.css:1: #content
On 2017/10/18 08:07:54, ire wrote:
> NIT: Maybe add a comment why a non-LSD-related selector is in this file? I
know
> you will probably be the one to change this soon, so it's probably not that
> important

Agreed.

Powered by Google App Engine
This is Rietveld