Noissue - Refactored new abp.org mobile heading sizes

Noissue - Refactored mobile heading sizes

[ire, 2017-10-20 07:33:27]

(=This patch doesn't apply

[ire, 2017-10-20 07:34:08]

On 2017/10/20 07:33:27, ire wrote:
> (=This patch doesn't apply

This was a typo that turned out to be a smiley (=

[ire, 2017-10-20 07:36:01]

One NIT. You can address it if you agree. LGTM

https://codereview.adblockplus.org/29581842/diff/29581843/static/css/main.css
File static/css/main.css (right):

https://codereview.adblockplus.org/29581842/diff/29581843/static/css/main.css...
static/css/main.css:167: @media(min-width: 1200px)
NIT: I think this is too wide? I think the larger sizes could be applied at a
smaller breakpoint (tablet/desktop-width)

[juliandoucette, 2017-10-20 13:52:15]

Thanks :)

https://codereview.adblockplus.org/29581842/diff/29581843/static/css/main.css
File static/css/main.css (right):

https://codereview.adblockplus.org/29581842/diff/29581843/static/css/main.css...
static/css/main.css:167: @media(min-width: 1200px)
On 2017/10/20 07:36:00, ire wrote:
> NIT: I think this is too wide? I think the larger sizes could be applied at a
> smaller breakpoint (tablet/desktop-width)

Agreed. We can use a variable for this purpose.

[juliandoucette, 2017-10-20 14:03:16]

https://codereview.adblockplus.org/29581842/diff/29581843/static/css/main.css
File static/css/main.css (right):

https://codereview.adblockplus.org/29581842/diff/29581843/static/css/main.css...
static/css/main.css:167: @media(min-width: 1200px)
On 2017/10/20 13:52:15, juliandoucette wrote:
> On 2017/10/20 07:36:00, ire wrote:
> > NIT: I think this is too wide? I think the larger sizes could be applied at
a
> > smaller breakpoint (tablet/desktop-width)
> 
> Agreed. We can use a variable for this purpose.

I was thinking about website-defaults :D

[juliandoucette, 2017-10-20 14:07:27]

Done.

[juliandoucette, 2017-10-20 14:08:12]

https://bitbucket.org/adblockplus/adblockplus.org/commits/5a471962c2502787167...