Issue 5880 - Basic issue reporter implementation

This is mostly working, a few outstanding issues: 1) No error is being displayed if sending failed, 2) Clicking report link will show it in the frame, we want to replace the parent document instead, 3) Display of report data is suboptimal.

[Wladimir Palant, 2017-10-19 14:03:09]

Patch Set 2 added proper error handling. Also, the frame showing submission
results now allows the document to navigate the top frame. This means that we
can add target="_top" to the report link on the server side and clicking it will
replace the issue reporter document.

[Wladimir Palant, 2017-10-19 14:07:24]

Patch Set 3 made sure that our bubble doesn't offer reporting issues for local
pages.

[Felix Dahlke, 2017-10-19 16:48:05]

LGTM. I've left one comment, but since we're in a hurry, I'm fine with
addressing this in a follow-up issue.

Also, as discussed, this should be in adblockplusui rather than
adblockpluschrome, but I don't mind addressing that later, either. There's a few
other things we have yet to move anyway. But please update
adblockplus.org/modules to include `issue-reporter.js` and `issue-reporter.html`
in the UI module.

https://codereview.adblockplus.org/29583568/diff/29583593/issue-reporter.js
File issue-reporter.js (right):

https://codereview.adblockplus.org/29583568/diff/29583593/issue-reporter.js#n...
issue-reporter.js:345: let url = "https://reports.adblockplus.org/submitReport?"
+ params;
Why not make this a pref?

[Wladimir Palant, 2017-10-19 17:54:26]

https://codereview.adblockplus.org/29583568/diff/29583593/issue-reporter.js
File issue-reporter.js (right):

https://codereview.adblockplus.org/29583568/diff/29583593/issue-reporter.js#n...
issue-reporter.js:345: let url = "https://reports.adblockplus.org/submitReport?"
+ params;
On 2017/10/19 16:48:04, Felix Dahlke wrote:
> Why not make this a pref?

Why make it a pref? It used to be a pref in the legacy Firefox extension, which
made sense for testing. But with Web Extensions hidden preferences aren't
exactly accessible.

[Felix Dahlke, 2017-10-19 18:21:31]

(Probably my last comment in this review, since I'm off tomorrow and next week.)

https://codereview.adblockplus.org/29583568/diff/29583593/issue-reporter.js
File issue-reporter.js (right):

https://codereview.adblockplus.org/29583568/diff/29583593/issue-reporter.js#n...
issue-reporter.js:345: let url = "https://reports.adblockplus.org/submitReport?"
+ params;
On 2017/10/19 17:54:25, Wladimir Palant wrote:
> On 2017/10/19 16:48:04, Felix Dahlke wrote:
> > Why not make this a pref?
> 
> Why make it a pref? It used to be a pref in the legacy Firefox extension,
which
> made sense for testing. But with Web Extensions hidden preferences aren't
> exactly accessible.

Two reasons:

1. Feels wrong to hard code URLs in general. We have most (if not all?) of them
in prefs.js already.
2. Makes it easier for forks to change (granted, they have to host their own
backend, but still).

But like I said, I wouldn't insist.