Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29584561: Issue 5895 - Don't resolve optional npm dependencies (Closed)

Created:
Oct. 20, 2017, 11:08 a.m. by tlucas
Modified:
Oct. 20, 2017, 12:07 p.m.
Reviewers:
kzar, Wladimir Palant
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue 5895 - Don't resolve optional npm dependencies

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ensure_dependencies.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
tlucas
Patch Set 1 * Pass '--no-optional' to 'npm install'
Oct. 20, 2017, 11:09 a.m. (2017-10-20 11:09:50 UTC) #1
Wladimir Palant
LGTM
Oct. 20, 2017, 11:28 a.m. (2017-10-20 11:28:16 UTC) #2
kzar
Oct. 20, 2017, 11:38 a.m. (2017-10-20 11:38:00 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld