sitescripts/reports/template/submitSuccess.html - Issue 29584689: Issue 5890 - Align the font of the issue reporter result page with the font of the extension UI

Delta Between Two Patch Sets: sitescripts/reports/template/submitSuccess.html

Issue 29584689: Issue 5890 - Align the font of the issue reporter result page with the font of the extension UI (Closed)

Left Patch Set: Created Oct. 20, 2017, 3:44 p.m.

Right Patch Set: Convert font size to pixels, set background. Created Oct. 22, 2017, 9:58 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <!--	1 <!--

2 - This file is part of the Adblock Plus web scripts,	2 - This file is part of the Adblock Plus web scripts,

3 - Copyright (C) 2006-present eyeo GmbH	3 - Copyright (C) 2006-present eyeo GmbH

4 -	4 -

5 - Adblock Plus is free software: you can redistribute it and/or modify	5 - Adblock Plus is free software: you can redistribute it and/or modify

6 - it under the terms of the GNU General Public License version 3 as	6 - it under the terms of the GNU General Public License version 3 as

7 - published by the Free Software Foundation.	7 - published by the Free Software Foundation.

8 -	8 -

9 - Adblock Plus is distributed in the hope that it will be useful,	9 - Adblock Plus is distributed in the hope that it will be useful,

10 - but WITHOUT ANY WARRANTY; without even the implied warranty of	10 - but WITHOUT ANY WARRANTY; without even the implied warranty of

11 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	11 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

12 - GNU General Public License for more details.	12 - GNU General Public License for more details.

13 -	13 -

14 - You should have received a copy of the GNU General Public License	14 - You should have received a copy of the GNU General Public License

15 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.	15 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

16 -->	16 -->

17	17

18 <html xmlns="http://www.w3.org/1999/xhtml">	18 <html xmlns="http://www.w3.org/1999/xhtml">

19 <head>	19 <head>

20 <title>Report submission</title>	20 <title>Report submission</title>

21 <style type="text/css">	21 <style type="text/css">

22 body {	22 body
Wladimir Palant 2017/10/21 18:14:42 Nit: this bracket belongs on the next line. Nit: this bracket belongs on the next line. Vasily Kuznetsov 2017/10/22 09:59:31 Done. Show quoted text On 2017/10/21 18:14:42, Wladimir Palant wrote: > Nit: this bracket belongs on the next line. Done.
	23 {

23 font-family: Segoe UI, Arial, sans-serif;	24 font-family: Segoe UI, Arial, sans-serif;

24 font-size: 1.25rem;	25 font-size: 20px;
Vasily Kuznetsov 2017/10/20 15:53:41 I used 1.25rem instead of 20px as in the ticket si I used 1.25rem instead of 20px as in the ticket since this is what the extension CSS uses. I also made the font color the same as in the extension page for more consistent appearance. Wladimir Palant 2017/10/21 18:14:42 The trouble is that I likely need to change that i Show quoted text On 2017/10/20 15:53:41, Vasily Kuznetsov wrote: > I used 1.25rem instead of 20px as in the ticket since this is what the extension > CSS uses. I also made the font color the same as in the extension page for more > consistent appearance. The trouble is that I likely need to change that in the issue reporter. rem refers to the size defined in the root element - and the issue reporter doesn't currently define it, so we get the default (usually 16px but not guaranteed to be that). New options page actually defines font size in <html> but IMHO one can just set font-size to 20px for the body tag then. Vasily Kuznetsov 2017/10/22 09:59:31 Done. Show quoted text On 2017/10/21 18:14:42, Wladimir Palant wrote: > On 2017/10/20 15:53:41, Vasily Kuznetsov wrote: > > I used 1.25rem instead of 20px as in the ticket since this is what the > extension > > CSS uses. I also made the font color the same as in the extension page for > more > > consistent appearance. > > The trouble is that I likely need to change that in the issue reporter. rem > refers to the size defined in the root element - and the issue reporter doesn't > currently define it, so we get the default (usually 16px but not guaranteed to > be that). New options page actually defines font size in <html> but IMHO one can > just set font-size to 20px for the body tag then. Done.
25 color: #494949;	26 color: #494949;
Wladimir Palant 2017/10/21 18:14:42 You cannot define text color without setting backg You cannot define text color without setting background color as well - you don't know what the default background is for the browser. background-color should be #ffffff. Vasily Kuznetsov 2017/10/22 09:59:31 Done. Show quoted text On 2017/10/21 18:14:42, Wladimir Palant wrote: > You cannot define text color without setting background color as well - you > don't know what the default background is for the browser. background-color > should be #ffffff. Done.
	27 background-color: #ffffff;

26 }	28 }

27 </style>	29 </style>

28 </head>	30 </head>

29 <body>	31 <body>

30 {% if knownIssues -%}	32 {% if knownIssues -%}

31 <p><strong>%KNOWNISSUE%</strong>	33 <p><strong>%KNOWNISSUE%</strong>

32 {%- for issue in knownIssues -%}	34 {%- for issue in knownIssues -%}

33 <br /><a target="_top" href="{{issue}}">{{issue}}</a>	35 <br /><a target="_top" href="{{issue}}">{{issue}}</a>

34 {%- endfor -%}	36 {%- endfor -%}

35 </p>	37 </p>

36 {%- endif %}	38 {%- endif %}

37 <p>%CONFIRMATION% <a id="link" target="_top" href="{{url}}">{{url}}</a></p>	39 <p>%CONFIRMATION% <a id="link" target="_top" href="{{url}}">{{url}}</a></p>

38 </body>	40 </body>

39 </html>	41 </html>

LEFT	RIGHT