Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29584689: Issue 5890 - Align the font of the issue reporter result page with the font of the extension UI (Closed)

Created:
Oct. 20, 2017, 3:44 p.m. by Vasily Kuznetsov
Modified:
Oct. 23, 2017, 10:11 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 5890 - Align the font of the issue reporter result page with the font of the extension UI Repository: https://hg.adblockplus.org/sitescripts Base revision: this review https://codereview.adblockplus.org/29584686/

Patch Set 1 #

Total comments: 7

Patch Set 2 : Convert font size to pixels, set background. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M sitescripts/reports/template/submitSuccess.html View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Vasily Kuznetsov
Hi Wladimir, This follows the #5889 patch. Cheers, Vasily https://codereview.adblockplus.org/29584689/diff/29584690/sitescripts/reports/template/submitSuccess.html File sitescripts/reports/template/submitSuccess.html (right): https://codereview.adblockplus.org/29584689/diff/29584690/sitescripts/reports/template/submitSuccess.html#newcode24 sitescripts/reports/template/submitSuccess.html:24: ...
Oct. 20, 2017, 3:53 p.m. (2017-10-20 15:53:42 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29584689/diff/29584690/sitescripts/reports/template/submitSuccess.html File sitescripts/reports/template/submitSuccess.html (right): https://codereview.adblockplus.org/29584689/diff/29584690/sitescripts/reports/template/submitSuccess.html#newcode22 sitescripts/reports/template/submitSuccess.html:22: body { Nit: this bracket belongs on the next ...
Oct. 21, 2017, 6:14 p.m. (2017-10-21 18:14:42 UTC) #2
Vasily Kuznetsov
https://codereview.adblockplus.org/29584689/diff/29584690/sitescripts/reports/template/submitSuccess.html File sitescripts/reports/template/submitSuccess.html (right): https://codereview.adblockplus.org/29584689/diff/29584690/sitescripts/reports/template/submitSuccess.html#newcode22 sitescripts/reports/template/submitSuccess.html:22: body { On 2017/10/21 18:14:42, Wladimir Palant wrote: > ...
Oct. 22, 2017, 9:59 a.m. (2017-10-22 09:59:32 UTC) #3
Wladimir Palant
Oct. 22, 2017, 2:10 p.m. (2017-10-22 14:10:24 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld