Make mimeo module only listen to localhost

Make mimeo module only listen to localhost

[f.nicolaisen, 2017-10-23 15:46:53]

Please point out in the commit message that you're only changing the default
configuration.

[rscott, 2017-10-23 16:01:10]

LGTM

[Vasily Kuznetsov, 2017-10-24 16:01:53]

LGTM on the code, but the commit message should be either 'Noissue - Introduce
command line option ... and change default to to localhost' or (preferred)
'Issue xxyy - Whatever'.

[mathias, 2017-10-24 16:20:01]

On 2017/10/24 16:01:53, Vasily Kuznetsov wrote:
> LGTM on the code, but the commit message should be either 'Noissue - Introduce
> command line option ... and change default to to localhost' or (preferred)
> 'Issue xxyy - Whatever'.

LGTM. And no, there's no Noissue in front of my module's commit messages any
more. The `Issue #... -` pattern we use for ABP issue reports, `#... - ...` for
Hub ones (yes I know it's not public yet but we need to start with something,
test it ourselves, before migrating more development modules later and
recommending practices), and no cargo cult for no issue relations.

[Vasily Kuznetsov, 2017-10-24 16:24:05]

On 2017/10/24 16:20:01, mathias wrote:
> On 2017/10/24 16:01:53, Vasily Kuznetsov wrote:
> > LGTM on the code, but the commit message should be either 'Noissue -
Introduce
> > command line option ... and change default to to localhost' or (preferred)
> > 'Issue xxyy - Whatever'.
> 
> LGTM. And no, there's no Noissue in front of my module's commit messages any
> more. The `Issue #... -` pattern we use for ABP issue reports, `#... - ...`
for
> Hub ones (yes I know it's not public yet but we need to start with something,
> test it ourselves, before migrating more development modules later and
> recommending practices), and no cargo cult for no issue relations.

Fair enough, but at least the commit message should mention both changes: (1)
listen only on localhost and (2) introduce command line option.

[mathias, 2017-10-24 16:39:07]

On 2017/10/24 16:24:05, Vasily Kuznetsov wrote:
> Fair enough, but at least the commit message should mention both changes: (1)
> listen only on localhost and (2) introduce command line option.

Right, the commit message is not optimal. @paco What Vasily wrote. You can use
the classic do/what/where pattern: "Introduce --address parameter with mimeo.py
script". The default now being localhost is an implicit detail one can neglect
in the commit message, IMHO, irregardless whether it was the initial motivation.
But since there's no associated ticket for background information, associated
details like the motivation for this patch-set should end up in the extended
part of the commit message.