Issue 29587558: Issue 5868 - Allow clicking outside CustomSelect to close in help.eyeo.com

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29587558: Issue 5868 - Allow clicking outside CustomSelect to close in help.eyeo.com (Closed)

Created:
Oct. 24, 2017, 8:20 a.m. by ire

Modified:
Oct. 24, 2017, 2:51 p.m.

Reviewers:
juliandoucette

Base URL:
https://hg.adblockplus.org/help.eyeo.com

Visibility:
Public.

Description

Issue 5868 - Allow clicking outside CustomSelect to close in help.eyeo.com

Patch Set 1 #

Total comments: 2

Created: Oct. 24, 2017, 8:20 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -2 lines)			Patch
	M	includes/layout/footer.tmpl	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	static/js/main.js	View		1 chunk	+26 lines, -1 line	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

juliandoucette

LGTM https://codereview.adblockplus.org/29587558/diff/29587559/static/js/main.js File static/js/main.js (right): https://codereview.adblockplus.org/29587558/diff/29587559/static/js/main.js#newcode55 static/js/main.js:55: if (newFocus Suggest: {{{ var classList = document.activeElement.classList; ...

Oct. 24, 2017, 10:15 a.m. (2017-10-24 10:15:25 UTC) #3

ire

Oct. 24, 2017, 2:51 p.m. (2017-10-24 14:51:10 UTC) #4

https://codereview.adblockplus.org/29587558/diff/29587559/static/js/main.js
File static/js/main.js (right):

https://codereview.adblockplus.org/29587558/diff/29587559/static/js/main.js#n...
static/js/main.js:55: if (newFocus
On 2017/10/24 10:15:25, juliandoucette wrote:
> Suggest:
> 
> {{{
> var classList = document.activeElement.classList;
> 
> return classList.contains("custom-select-selected") ||
>   classList.contains("custom-select-option") ||
>   this.close();
> }}}

This particular way doesn't work because I'm not only checking for the
activeElement's class. Also checking for the parentElement of the activeElement.

Expand All Messages | Collapse All Messages