Unified Diff: includes/components/navbar.html
Issue 29587584:
Issue 5635 - Implement website-default navbar component (Closed)
Base URL: https://hg.adblockplus.org/website-defaults
Patch Set:
Created Oct. 24, 2017, 10:32 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
pages/index.html » ('j')
|
pages/navbar.md » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: includes/components/navbar.html |
| =================================================================== |
| new file mode 100644 |
| --- /dev/null |
| +++ b/includes/components/navbar.html |
| @@ -0,0 +1,20 @@ |
| +<div class="navbar"> |
|
juliandoucette
2017/10/26 15:55:55
suggest: navbar.tmpl (see template usage examples
|
| + <div class="container"> |
|
juliandoucette
2017/10/26 15:55:54
NIT: I suggest we point out that .container is opt
juliandoucette
2017/10/26 15:58:01
This is inconsistent with my surrounding suggestio
|
| + <h1 class="navbar-branding"> |
|
juliandoucette
2017/10/26 15:55:54
Note: I'm not sure that an h1 is appropriate
juliandoucette
2017/10/26 15:55:55
suggest: "navbar-brand"
|
| + <a href="index">Website Defaults</a> |
|
juliandoucette
2017/10/26 15:55:55
suggest: make this more extensible e.g.
{{ "index
|
| + </h1> |
| + |
| + <button class="toggle-navbar-collapse"> |
|
juliandoucette
2017/10/26 15:55:55
suggest: "navbar-toggle"
|
| + <span class="open-label">Open</span> |
|
juliandoucette
2017/10/26 15:55:55
suggest: a shared hamberger icon
|
| + <span class="sr-only">/</span> |
| + <span class="close-label">Close</span> |
| + Menu |
| + </button> |
| + |
|
juliandoucette
2017/10/26 15:55:55
suggest: enableable navbar search
|
| + <div class="navbar-collapse"> |
| + <nav> |
| + <a href="index">Navbar Menu Link</a> |
|
juliandoucette
2017/10/26 15:55:55
suggest: loop an array of pages and external links
juliandoucette
2017/10/26 15:55:55
suggest: More than one example link
|
| + </nav> |
| + </div> |
| + </div> |
|
juliandoucette
2017/10/26 15:55:54
suggest: enableable locale menu (separate include
|
| +</div> |
« no previous file with comments
|
« no previous file
|
pages/index.html » ('j')
|
pages/navbar.md » ('J')
