Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: static/js/navbar.js

Issue 29587584: Issue 5635 - Implement website-default navbar component (Closed) Base URL: https://hg.adblockplus.org/website-defaults
Patch Set: Demo of both methods Created Nov. 6, 2017, 8:18 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: static/js/navbar.js
===================================================================
new file mode 100644
--- /dev/null
+++ b/static/js/navbar.js
@@ -0,0 +1,33 @@
+/*******************************************************************************
+ * Navbar Component
juliandoucette 2017/11/06 12:36:43 BUG: You can't collapse the navbar if you expanded
ire 2017/11/08 17:14:46 I can't seem to reproduce this. If the navbar is o
juliandoucette 2017/11/09 14:34:51 Just re-tested. This only applied to the table lay
+ ******************************************************************************/
+
+document.addEventListener("DOMContentLoaded", function()
+{
+
+ function Navbar(navbar)
+ {
+ this.navbar = navbar;
+
+ this.navbar
+ .querySelector(".toggle-navbar-collapse button")
+ .addEventListener("click", this._onClick.bind(this), false);
+ }
+
+ Navbar.prototype.toggleCollapse = function()
+ {
+ this.navbar.classList.toggle("expanded");
+ };
+
+ Navbar.prototype._onClick = function()
+ {
+ this.toggleCollapse();
+ };
+
+ var navbars = document.getElementsByClassName("navbar");
+ for (var i = 0; i < navbars.length; i++)
+ {
+ new Navbar(navbars[i]);
+ }
+
+}, false);
« no previous file with comments | « pages/navbar.md ('k') | static/scss/_navbar.scss » ('j') | static/scss/_navbar.scss » ('J')

Powered by Google App Engine
This is Rietveld