Issue 5635 - Implement website-default navbar component

static/scss/_navbar.scss

Index: static/scss/_navbar.scss
===================================================================
new file mode 100644
--- /dev/null
+++ b/static/scss/_navbar.scss
@@ -0,0 +1,145 @@
+// This file is part of help.eyeo.com.
+// Copyright (C) 2017 Eyeo GmbH
+//
+// help.eyeo.com is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// help.eyeo.com is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with help.eyeo.com.  If not, see <http://www.gnu.org/licenses/>.
+
+/*******************************************************************************
+ * Navbar component
+ ******************************************************************************/
+
+.navbar
+{
+  @extend .clearfix;
+}
+
+.toggle-navbar-collapse,
+.navbar-collapse
+{
+  padding-top: $navbar-padding-v + ($navbar-padding-v / 2);

[juliandoucette, 2017/11/10 11:42:52]

I think that this assumes that .toggle-navbar-collapse height is (
$navbar-branding-height - $navbar-padding-v ) because the total navbar height
seems to be $navbar-branding-height + ( 2 * $navbar-padding-v ).

If I am correct then you are assuming a height instead of setting a height and
this will break/(be not helpful) if that height changes in a child website.

[ire, 2017/11/13 17:57:42]

You're right. The .toggle-navbar-collapse should actually be the <button> itself
(which I've changed). This way, the height of the .toggle-navbar-collapse is the
same as the .navbar itself.

+  padding-bottom: $navbar-padding-v + ($navbar-padding-v / 2);
+}
+
+/* .navbar .navbar-branding
+  ****************************************************************************/

[juliandoucette, 2017/11/10 11:42:52]

NIT: There is supposed to be one space before the first "*" so that the first
line "*" and the second line "*" align. And the line is supposed to be
consistently 79 or 80 characters long.

[ire, 2017/11/13 17:57:41]

Done.

+
+.navbar-branding

[juliandoucette, 2017/11/10 11:42:53]

NIT/Suggest: Add padding-x to the navbar-branding so that the focus box doesn't
hug the sides of the logo image/text (e.g. margin-start: -1em; padding-start:
1em - like new abp.org)

[juliandoucette, 2017/11/10 11:42:53]

Suggest: Add a hover/active/focus background color

+{
+  padding-top: $navbar-padding-v;
+  padding-bottom: $navbar-padding-v;
+}
+
+.navbar-branding img
+{
+  height: $navbar-branding-height;
+}
+
+/* .navbar .toggle-navbar-collapse
+  ****************************************************************************/
+
+.toggle-navbar-collapse

[juliandoucette, 2017/11/10 11:42:52]

TOL: Are these properties that should apply to `.unstyled`? If so,
toggle-navbar-collapse could extend .unstyled.

[ire, 2017/11/13 17:57:42]

Done.

+{
+  display: none;
+  border: 0;
+  background-color: transparent;
+  cursor: pointer;
+}
+
+.js .toggle-navbar-collapse
+{
+  display: block;
+
+  @media (min-width: $tablet-breakpoint)
+  {
+    display: none;
+  }
+}
+
+.js .toggle-navbar-collapse .close-label
+{
+  display: none;
+}
+
+.expanded .toggle-navbar-collapse .open-label
+{
+  display: none;
+}
+
+.expanded .toggle-navbar-collapse .close-label
+{
+  display: inline;
+}
+
+/* .navbar .navbar-collapse

[juliandoucette, 2017/11/10 11:42:53]

Suggest: Add padding/space to the <a> themselves instead of their containers to
make the navbar links more like buttons and less like links.

[juliandoucette, 2017/11/10 11:42:53]

Suggest: Add an active/hover/focus background color to <a>

[ire, 2017/11/13 17:57:40]

Do we want them to look more like buttons? I know we do on abp but I don't think
this is the case for help center

[ire, 2017/11/13 17:57:42]

Same as previously answer. background-color applies only if we want it to not
look like a regular link.

+  ****************************************************************************/
+
+.navbar-collapse
+{
+  clear: both;
+  padding-top: 0;
+
+  @media (min-width: $tablet-breakpoint)
+  {
+    float: right;
+    clear: none;
+    padding-top: $navbar-padding-v + ($navbar-padding-v / 2);
+  }
+}
+
+[dir="rtl"] .navbar-collapse
+{
+  float: left;
+}
+
+.js .navbar-collapse
+{
+  display: none;
+
+  @media (min-width: $tablet-breakpoint)
+  {
+    display: block;
+  }
+}
+
+.expanded .navbar-collapse
+{
+  display: block;
+}
+
+/* .navbar .nav

[juliandoucette, 2017/11/10 11:42:52]

NIT/Suggest: Make the whole line and space above/below items clickable on mobile
(like custom-select) (Make the <a> block and add padding above/below).

+  ****************************************************************************/
+
+.navbar .nav li
+{
+  margin-bottom: $navbar-padding-v;
+
+  @media (min-width: $tablet-breakpoint)
+  {
+    display: inline-block;
+    margin: 0 0 0 $navbar-padding-v;
+  }
+}
+
+[dir="rtl"] .navbar .nav li
+{
+  @media (min-width: $tablet-breakpoint)
+  {
+    display: inline-block;
+    margin: 0 $navbar-padding-v 0 0;
+  }
+}
+
+.navbar .nav li:last-child
+{
+  margin-bottom: 0;
+}