Unified Diff: includes/components/navbar.html
Issue 29587584:
Issue 5635 - Implement website-default navbar component (Closed)
Base URL: https://hg.adblockplus.org/website-defaults
Patch Set: Addressed NITs
Created Nov. 13, 2017, 5:19 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
pages/index.html » ('j')
|
static/js/navbar.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: includes/components/navbar.html |
| =================================================================== |
| new file mode 100644 |
| --- /dev/null |
| +++ b/includes/components/navbar.html |
| @@ -0,0 +1,23 @@ |
| +<div class="navbar bg-primary"> |
| + <div class="container"> |
| + <a href="index" class="navbar-branding float-start"> |
| + <img src="/img/png/eyeo-logo.png" srcset="/img/svg/eyeo-logo.svg 2x" alt="eyeo"> |
| + </a> |
| + |
| + <button class="toggle-navbar-collapse float-end"> |
|
juliandoucette
2017/11/15 12:56:42
NIT: It seems inconsistent that you use .float-end
ire
2017/11/30 14:01:18
The reason I did this was because, for the .navbar
|
| + <span class="open-label">Open</span> |
| + <span class="sr-only">/</span> |
| + <span class="close-label">Close</span> |
| + Menu |
| + </button> |
| + |
| + <nav class="navbar-nav navbar-collapse"> |
| + <ul> |
| + <li><a href="index">Navbar Menu Link</a></li> |
| + <li><a href="index">Navbar Menu Link</a></li> |
| + <li><a href="index">Navbar Menu Link</a></li> |
| + <li><a href="index">Navbar Menu Link</a></li> |
| + </ul> |
| + </nav> |
| + </div> |
| +</div> |
« no previous file with comments
|
« no previous file
|
pages/index.html » ('j')
|
static/js/navbar.js » ('J')
