Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29587599: Issue 5887 - Issue reporter should use the SVG Adblock Plus logo (Closed)

Created:
Oct. 24, 2017, 10:45 a.m. by Wladimir Palant
Modified:
Oct. 24, 2017, 2:12 p.m.
Reviewers:
Manish Jethani, kzar
CC:
Thomas Greiner
Base URL:
https://hg.adblockplus.org/adblockplusui
Visibility:
Public.

Description

Issue 5887 - Issue reporter should use the SVG Adblock Plus logo

Patch Set 1 #

Total comments: 2

Patch Set 2 : Set image size explicitly #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M issue-reporter.html View 1 chunk +1 line, -1 line 0 comments Download
M skin/issue-reporter.css View 1 2 chunks +10 lines, -0 lines 1 comment Download

Messages

Total messages: 6
Wladimir Palant
Oct. 24, 2017, 10:45 a.m. (2017-10-24 10:45:16 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29587599/diff/29587600/issue-reporter.html File issue-reporter.html (right): https://codereview.adblockplus.org/29587599/diff/29587600/issue-reporter.html#newcode12 issue-reporter.html:12: <img id="logo" alt="Adblock Plus logo" src="skin/abp-logo.svg"> For reference: I'm ...
Oct. 24, 2017, 10:46 a.m. (2017-10-24 10:46:38 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29587599/diff/29587600/issue-reporter.html File issue-reporter.html (right): https://codereview.adblockplus.org/29587599/diff/29587600/issue-reporter.html#newcode12 issue-reporter.html:12: <img id="logo" alt="Adblock Plus logo" src="skin/abp-logo.svg"> On 2017/10/24 10:46:38, ...
Oct. 24, 2017, 11 a.m. (2017-10-24 11:00:04 UTC) #3
kzar
Isn't skin/abp-logo.svg only mapped for the gecko build at the moment?
Oct. 24, 2017, 1:15 p.m. (2017-10-24 13:15:42 UTC) #4
Wladimir Palant
On 2017/10/24 13:15:42, kzar wrote: > Isn't skin/abp-logo.svg only mapped for the gecko build at ...
Oct. 24, 2017, 1:21 p.m. (2017-10-24 13:21:23 UTC) #5
kzar
Oct. 24, 2017, 2:04 p.m. (2017-10-24 14:04:09 UTC) #6
On 2017/10/24 13:21:23, Wladimir Palant wrote:
> It's not mapped at all - see integration notes in the issue.

Gotya, LGTM.

Powered by Google App Engine
This is Rietveld