Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(244)

Issue 29587613: Issue 5917 - Improve display of report data in the issue reporter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by Wladimir Palant
Modified:
2 years, 2 months ago
Reviewers:
Manish Jethani, kzar
CC:
Thomas Greiner
Base URL:
https://hg.adblockplus.org/adblockplusui/
Visibility:
Public.

Description

Issue 5917 - Improve display of report data in the issue reporter

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -8 lines) Patch
M issue-reporter.html View 1 chunk +7 lines, -0 lines 2 comments Download
M issue-reporter.js View 1 chunk +31 lines, -8 lines 2 comments Download
M skin/issue-reporter.css View 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
2 years, 2 months ago (2017-10-24 11:55:37 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29587613/diff/29587614/issue-reporter.html File issue-reporter.html (right): https://codereview.adblockplus.org/29587613/diff/29587614/issue-reporter.html#newcode101 issue-reporter.html:101: <button id="showDataClose" class="i18n_cancel primary"></button> It would be better for ...
2 years, 2 months ago (2017-10-24 11:58:29 UTC) #2
kzar
2 years, 2 months ago (2017-10-24 13:39:57 UTC) #3
LGTM, maybe someone else should check the CSS though.

https://codereview.adblockplus.org/29587613/diff/29587614/issue-reporter.html
File issue-reporter.html (right):

https://codereview.adblockplus.org/29587613/diff/29587614/issue-reporter.html...
issue-reporter.html:101: <button id="showDataClose" class="i18n_cancel
primary"></button>
On 2017/10/24 11:58:29, Wladimir Palant wrote:
> It would be better for this button to say "Close" or "OK" rather than
"Cancel."
> However, "Cancel" is the only string we have translations for right now and
> currently we cannot add new strings.

Acknowledged.

https://codereview.adblockplus.org/29587613/diff/29587614/issue-reporter.js
File issue-reporter.js (left):

https://codereview.adblockplus.org/29587613/diff/29587614/issue-reporter.js#o...
issue-reporter.js:313: });
On 2017/10/24 11:58:29, Wladimir Palant wrote:
> It would have been possible to merely fix this call. However, showing report
> data in a new tab was only meant to be a stopgap solution anyway, we can
replace
> it by something more usable while at it.

Acknowledged.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5