Issue 29587613: Issue 5917 - Improve display of report data in the issue reporter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29587613: Issue 5917 - Improve display of report data in the issue reporter (Closed)

Created:
Oct. 24, 2017, 11:55 a.m. by Wladimir Palant

Modified:
Oct. 24, 2017, 2:12 p.m.

Reviewers:
Manish Jethani, kzar

CC:
Thomas Greiner

Base URL:
https://hg.adblockplus.org/adblockplusui/

Visibility:
Public.

Description

Issue 5917 - Improve display of report data in the issue reporter

Patch Set 1 #

Total comments: 4

Created: Oct. 24, 2017, 11:55 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -8 lines)			Patch
M	issue-reporter.html	View	1 chunk	+7 lines, -0 lines	2 comments	Download
M	issue-reporter.js	View	1 chunk	+31 lines, -8 lines	2 comments	Download
M	skin/issue-reporter.css	View	2 chunks	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Wladimir Palant

https://codereview.adblockplus.org/29587613/diff/29587614/issue-reporter.html File issue-reporter.html (right): https://codereview.adblockplus.org/29587613/diff/29587614/issue-reporter.html#newcode101 issue-reporter.html:101: <button id="showDataClose" class="i18n_cancel primary"></button> It would be better for ...

Oct. 24, 2017, 11:58 a.m. (2017-10-24 11:58:29 UTC) #2

kzar

Oct. 24, 2017, 1:39 p.m. (2017-10-24 13:39:57 UTC) #3

LGTM, maybe someone else should check the CSS though.

https://codereview.adblockplus.org/29587613/diff/29587614/issue-reporter.html
File issue-reporter.html (right):

https://codereview.adblockplus.org/29587613/diff/29587614/issue-reporter.html...
issue-reporter.html:101: <button id="showDataClose" class="i18n_cancel
primary"></button>
On 2017/10/24 11:58:29, Wladimir Palant wrote:
> It would be better for this button to say "Close" or "OK" rather than
"Cancel."
> However, "Cancel" is the only string we have translations for right now and
> currently we cannot add new strings.

Acknowledged.

https://codereview.adblockplus.org/29587613/diff/29587614/issue-reporter.js
File issue-reporter.js (left):

https://codereview.adblockplus.org/29587613/diff/29587614/issue-reporter.js#o...
issue-reporter.js:313: });
On 2017/10/24 11:58:29, Wladimir Palant wrote:
> It would have been possible to merely fix this call. However, showing report
> data in a new tab was only meant to be a stopgap solution anyway, we can
replace
> it by something more usable while at it.

Acknowledged.

Expand All Messages | Collapse All Messages