Issue 5891 - Add missing subscription information to issue reporter

Issue 5891 - Add missing subscription information to issue reporter

[kzar, 2017-10-24 14:14:19]

https://codereview.adblockplus.org/29587637/diff/29587638/messageResponder.js
File messageResponder.js (right):

https://codereview.adblockplus.org/29587637/diff/29587638/messageResponder.js...
messageResponder.js:413: result.disabledFilters = s.filters
Does this pass linting? The indentation seems a little weird and the parenthesis
for the one argument functions are superfluous.

[Wladimir Palant, 2017-10-24 14:18:59]

https://codereview.adblockplus.org/29587637/diff/29587638/messageResponder.js
File messageResponder.js (right):

https://codereview.adblockplus.org/29587637/diff/29587638/messageResponder.js...
messageResponder.js:413: result.disabledFilters = s.filters
On 2017/10/24 14:14:18, kzar wrote:
> Does this pass linting? The indentation seems a little weird and the
parenthesis
> for the one argument functions are superfluous.

Yes, it passes linting. I'd normally align the dots but this doesn't work here.
As to parentheses around single parameters - not something I'd normally do, but
the surrounding code does that. Thomas prefers it this way, so I decided to keep
things consistent.

[kzar, 2017-10-24 14:20:24]

LGTM

https://codereview.adblockplus.org/29587637/diff/29587638/messageResponder.js
File messageResponder.js (right):

https://codereview.adblockplus.org/29587637/diff/29587638/messageResponder.js...
messageResponder.js:413: result.disabledFilters = s.filters
On 2017/10/24 14:18:59, Wladimir Palant wrote:
> On 2017/10/24 14:14:18, kzar wrote:
> > Does this pass linting? The indentation seems a little weird and the
> parenthesis
> > for the one argument functions are superfluous.
> 
> Yes, it passes linting. I'd normally align the dots but this doesn't work
here.
> As to parentheses around single parameters - not something I'd normally do,
but
> the surrounding code does that. Thomas prefers it this way, so I decided to
keep
> things consistent.

Fair enough, it's Thomas' module after all.

[Manish Jethani, 2017-10-24 14:38:25]

https://codereview.adblockplus.org/29587637/diff/29587638/messageResponder.js
File messageResponder.js (right):

https://codereview.adblockplus.org/29587637/diff/29587638/messageResponder.js...
messageResponder.js:413: result.disabledFilters = s.filters
On 2017/10/24 14:18:59, Wladimir Palant wrote:
> On 2017/10/24 14:14:18, kzar wrote:
> > Does this pass linting? The indentation seems a little weird and the
> parenthesis
> > for the one argument functions are superfluous.
> 
> Yes, it passes linting. I'd normally align the dots but this doesn't work
here.

How about moving s.filter to the next line with a 2-space indent?

LGTM

[Wladimir Palant, 2017-10-25 11:05:01]

https://codereview.adblockplus.org/29587637/diff/29587638/messageResponder.js
File messageResponder.js (right):

https://codereview.adblockplus.org/29587637/diff/29587638/messageResponder.js...
messageResponder.js:413: result.disabledFilters = s.filters
On 2017/10/24 14:38:25, Manish Jethani wrote:
> How about moving s.filter to the next line with a 2-space indent?

Not convinced that this would be better, so I better leave things as they are.