Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29587652: Issue 5913 - call correct npm executable on Win (Closed)

Created:
Oct. 24, 2017, 1:39 p.m. by tlucas
Modified:
Oct. 24, 2017, 11:14 p.m.
Reviewers:
kzar, Oleksandr
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue 5913 - call correct npm executable on Win

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M ensure_dependencies.py View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 3
tlucas
Patch Set 1 * Call correct npm executable on Windows
Oct. 24, 2017, 2:11 p.m. (2017-10-24 14:11:49 UTC) #1
kzar
It seems madness that %PATHEXT% isn't honoured, but I don't have any better suggestions than ...
Oct. 24, 2017, 2:48 p.m. (2017-10-24 14:48:31 UTC) #2
Oleksandr
Oct. 24, 2017, 9:47 p.m. (2017-10-24 21:47:41 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld