Issue 29587711: Issue 5632 - New label next to the Privacy Friendly Acceptable Ads

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29587711: Issue 5632 - New label next to the Privacy Friendly Acceptable Ads (Closed)

Created:
Oct. 24, 2017, 4:55 p.m. by saroyanm

Modified:
Oct. 25, 2017, 8:47 a.m.

Reviewers:
ire

Visibility:
Public.

Description

Issue 5632 - New label next to the Privacy Friendly Acceptable Ads

Patch Set 1 #

Created: Oct. 24, 2017, 4:55 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	desktop-options.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	skin/desktop-options.css	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

saroyanm

@Ire can you please have a look, while we have already pushed the string for ...

Oct. 24, 2017, 4:56 p.m. (2017-10-24 16:56:58 UTC) #1

ire

Oct. 25, 2017, 8:40 a.m. (2017-10-25 08:40:46 UTC) #2

On 2017/10/24 16:56:58, saroyanm wrote:
> @Ire can you please have a look, while we have already pushed the string for
the
> "New" label, I think we can reintroduce the label here.
> 
> https://hg.adblockplus.org/adblockplusui/rev/a65aba31839f#l4.20

LGTM

Expand All Messages | Collapse All Messages