Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29588566: Issue 5881 - Fix link to Android NDK website in README (Closed)

Created:
Oct. 25, 2017, 8:31 a.m. by anton
Modified:
Nov. 2, 2017, 10:04 a.m.
Reviewers:
diegocarloslima, jens
CC:
René Jeschke
Visibility:
Public.

Description

Issue 5881 - Fix link to Android NDK website in README

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M README.md View 1 chunk +2 lines, -2 lines 4 comments Download

Messages

Total messages: 4
anton
https://codereview.adblockplus.org/29588566/diff/29588567/README.md File README.md (right): https://codereview.adblockplus.org/29588566/diff/29588567/README.md#newcode66 README.md:66: * [The Android SDK](https://developer.android.com/sdk) not related but i'd prefer ...
Oct. 25, 2017, 8:33 a.m. (2017-10-25 08:33:04 UTC) #1
jens
On 2017/10/25 08:33:04, anton wrote: > https://codereview.adblockplus.org/29588566/diff/29588567/README.md > File README.md (right): > > https://codereview.adblockplus.org/29588566/diff/29588567/README.md#newcode66 > ...
Oct. 25, 2017, 8:36 a.m. (2017-10-25 08:36:06 UTC) #2
jens
https://codereview.adblockplus.org/29588566/diff/29588567/README.md File README.md (right): https://codereview.adblockplus.org/29588566/diff/29588567/README.md#newcode66 README.md:66: * [The Android SDK](https://developer.android.com/sdk) On 2017/10/25 08:33:04, anton wrote: ...
Oct. 25, 2017, 8:36 a.m. (2017-10-25 08:36:11 UTC) #3
diegocarloslima
Nov. 2, 2017, 10:01 a.m. (2017-11-02 10:01:10 UTC) #4
On 2017/10/25 08:36:11, jens wrote:
> https://codereview.adblockplus.org/29588566/diff/29588567/README.md
> File README.md (right):
> 
> https://codereview.adblockplus.org/29588566/diff/29588567/README.md#newcode66
> README.md:66: * [The Android SDK](https://developer.android.com/sdk)
> On 2017/10/25 08:33:04, anton wrote:
> > not related but i'd prefer to make it consistent with NDK link too
> 
> Acknowledged.
> 
> https://codereview.adblockplus.org/29588566/diff/29588567/README.md#newcode68
> README.md:68: * [The Android NDK, 12b](https://developer.android.com/ndk)
> On 2017/10/25 08:33:04, anton wrote:
> > forwarded to ../ndk/index.html but looks consistent with SDK link
> 
> Acknowledged.

LGTM

Powered by Google App Engine
This is Rietveld