Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: static/scss/content/_typography.scss

Issue 29588588: Issue 5848 - Fix vertical alignment on .heading-icon images in help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Created Oct. 25, 2017, 10:21 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: static/scss/content/_typography.scss
===================================================================
--- a/static/scss/content/_typography.scss
+++ b/static/scss/content/_typography.scss
@@ -47,31 +47,20 @@
text-transform: uppercase;
}
a
{
color: $font-color-link;
}
-.heading-icon
-{
- height: 0.9em;
- margin-right: 0.3em;
-}
-
-[dir="rtl"] .heading-icon
-{
- margin-right: 0;
- margin-left: 0.3em;
-}
-
.product-heading
{
@extend .h1;
@extend .section;
@extend .ta-center;
}
.article-heading
{
@extend .h2;
+ width: 100%;
juliandoucette 2017/10/26 11:42:57 Why do we need this? (Headings are usually block.)
ire 2017/10/30 09:45:37 Because of the icon-container, it's display:table
juliandoucette 2017/10/31 14:14:34 Ack. But it's not anymore?
ire 2017/11/01 07:57:24 Oops missed that. Done.
}

Powered by Google App Engine
This is Rietveld