Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29588596: Issue 5919 - Adjust our code to the new messaging system (Closed)

Created:
Oct. 25, 2017, 11:39 a.m. by diegocarloslima
Modified:
Nov. 3, 2017, 10:50 a.m.
Reviewers:
anton, jens
CC:
Felix Dahlke, René Jeschke
Visibility:
Public.

Description

Issue 5919 - Adjust our code to the new messaging system

Patch Set 1 #

Patch Set 2 : Removing Log statement #

Total comments: 4

Patch Set 3 : Adding missing return statements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -351 lines) Patch
M adblockplus/Api.jsm View 1 2 2 chunks +41 lines, -22 lines 0 comments Download
M mobile/android/thirdparty/org/adblockplus/browser/AbpCheckBoxPreference.java View 2 chunks +12 lines, -16 lines 0 comments Download
M mobile/android/thirdparty/org/adblockplus/browser/AdblockPlusApiCallback.java View 1 chunk +2 lines, -2 lines 0 comments Download
M mobile/android/thirdparty/org/adblockplus/browser/AddOnBridge.java View 1 4 chunks +161 lines, -266 lines 0 comments Download
M mobile/android/thirdparty/org/adblockplus/browser/BrowserAppUtils.java View 1 chunk +12 lines, -12 lines 0 comments Download
M mobile/android/thirdparty/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java View 4 chunks +20 lines, -23 lines 0 comments Download
M mobile/android/thirdparty/org/adblockplus/browser/SubscriptionContainer.java View 4 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 5
diegocarloslima
Oct. 25, 2017, 11:44 a.m. (2017-10-25 11:44:07 UTC) #1
anton
https://codereview.adblockplus.org/29588596/diff/29588605/adblockplus/Api.jsm File adblockplus/Api.jsm (right): https://codereview.adblockplus.org/29588596/diff/29588605/adblockplus/Api.jsm#newcode234 adblockplus/Api.jsm:234: callback.onError("malformed request"); should not `return` be added here? https://codereview.adblockplus.org/29588596/diff/29588605/adblockplus/Api.jsm#newcode239 ...
Oct. 30, 2017, 1:16 p.m. (2017-10-30 13:16:55 UTC) #2
diegocarloslima
https://codereview.adblockplus.org/29588596/diff/29588605/adblockplus/Api.jsm File adblockplus/Api.jsm (right): https://codereview.adblockplus.org/29588596/diff/29588605/adblockplus/Api.jsm#newcode234 adblockplus/Api.jsm:234: callback.onError("malformed request"); On 2017/10/30 13:16:55, anton wrote: > should ...
Oct. 30, 2017, 1:40 p.m. (2017-10-30 13:40:12 UTC) #3
anton
On 2017/10/30 13:40:12, diegocarloslima wrote: > https://codereview.adblockplus.org/29588596/diff/29588605/adblockplus/Api.jsm > File adblockplus/Api.jsm (right): > > https://codereview.adblockplus.org/29588596/diff/29588605/adblockplus/Api.jsm#newcode234 > ...
Nov. 2, 2017, 10:31 a.m. (2017-11-02 10:31:10 UTC) #4
jens
Nov. 2, 2017, 1:12 p.m. (2017-11-02 13:12:03 UTC) #5 
On 2017/11/02 10:31:10, anton wrote:
> On 2017/10/30 13:40:12, diegocarloslima wrote:
> >
https://codereview.adblockplus.org/29588596/diff/29588605/adblockplus/Api.jsm
> > File adblockplus/Api.jsm (right):
> > 
> >
>
https://codereview.adblockplus.org/29588596/diff/29588605/adblockplus/Api.jsm...
> > adblockplus/Api.jsm:234: callback.onError("malformed request");
> > On 2017/10/30 13:16:55, anton wrote:
> > > should not `return` be added here?
> > 
> > Acknowledged.
> > 
> >
>
https://codereview.adblockplus.org/29588596/diff/29588605/adblockplus/Api.jsm...
> > adblockplus/Api.jsm:239: callback.onError("filters not loaded");
> > On 2017/10/30 13:16:55, anton wrote:
> > > should not `return` be added here?
> > 
> > Acknowledged.
> 
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld