Noissue - Prevented collapse of vertical margin after navbar menu

Noissue - Prevented collapse of vertical margin after navbar menu

[ire, 2017-10-27 08:34:27]

Could you please give me some more information about what this is for? I can't
seem to find any difference between before and after this patch

[juliandoucette, 2017-10-27 09:06:11]

On 2017/10/27 08:34:27, ire wrote:
> Could you please give me some more information about what this is for? I can't
> seem to find any difference between before and after this patch

(Sorry)

This is only visible on mobile devices when the navbar menu is open. This
prevents the first [heading (or anything else really) in the body]s margin-top
from collapsing (effectively adding space between the navbar menu and the body
content - I chose to do it this way because we don't always want to add space
here e.g. we could put a colored section immediately afterwards that has it's
own padding)

[ire, 2017-10-27 12:39:47]

On 2017/10/27 09:06:11, juliandoucette wrote:
> On 2017/10/27 08:34:27, ire wrote:
> > Could you please give me some more information about what this is for? I
can't
> > seem to find any difference between before and after this patch
> 
> (Sorry)
> 
> This is only visible on mobile devices when the navbar menu is open. This
> prevents the first [heading (or anything else really) in the body]s margin-top
> from collapsing (effectively adding space between the navbar menu and the body
> content - I chose to do it this way because we don't always want to add space
> here e.g. we could put a colored section immediately afterwards that has it's
> own padding)

Thanks! I see what you're talking about now.

LGTM

[juliandoucette, 2017-10-30 12:05:44]

https://bitbucket.org/adblockplus/adblockplus.org/commits/88c475f4cf0617f5069...