Noissue - Updated defaults.css and refactored #navbar-container

Noissue - Updated defaults.css and refactored #navbar-container

[ire, 2017-10-27 08:43:11]

https://codereview.adblockplus.org/29588968/diff/29588969/static/css/main.css
File static/css/main.css (right):

https://codereview.adblockplus.org/29588968/diff/29588969/static/css/main.css...
static/css/main.css:195: padding-left: 0;
I see that you did this because of the mobile navigation. But this would mean
that the navbar won't be properly aligned with the rest of the content (unless
you remove the padding from there too?). 

The only solution I can think of would involve refactoring the mobile navbar
menu (maybe absolute position?)

(You can deal with this separately if you want)

[juliandoucette, 2017-10-27 08:59:37]

https://codereview.adblockplus.org/29588968/diff/29588969/static/css/main.css
File static/css/main.css (right):

https://codereview.adblockplus.org/29588968/diff/29588969/static/css/main.css...
static/css/main.css:195: padding-left: 0;
On 2017/10/27 08:43:11, ire wrote:
> I see that you did this because of the mobile navigation. But this would mean
> that the navbar won't be properly aligned with the rest of the content (unless
> you remove the padding from there too?). 

You may be referring to the homepage content? If so, the homepage is a separate
case. The logo and hamberger icon align properly with content on other pages.

> 
> The only solution I can think of would involve refactoring the mobile navbar
> menu (maybe absolute position?)
> 
> (You can deal with this separately if you want)

You may be referring to the content on the homepage. This is a separate case.
The start of the logo and the end of the menu icon align with the start and end
of content in other pages on mobile devices. I chose to use padding within the
logo and menu icon instead of margin around them so that their active/focus
states (which are visually distinguished) include that space before/after them.

[ire, 2017-10-27 12:30:09]

LGTM

https://codereview.adblockplus.org/29588968/diff/29588969/static/css/main.css
File static/css/main.css (right):

https://codereview.adblockplus.org/29588968/diff/29588969/static/css/main.css...
static/css/main.css:195: padding-left: 0;
On 2017/10/27 08:59:37, juliandoucette wrote:
> On 2017/10/27 08:43:11, ire wrote:
> > I see that you did this because of the mobile navigation. But this would
mean
> > that the navbar won't be properly aligned with the rest of the content
(unless
> > you remove the padding from there too?). 
> 
> You may be referring to the homepage content? If so, the homepage is a
separate
> case. The logo and hamberger icon align properly with content on other pages.
> 
> > 
> > The only solution I can think of would involve refactoring the mobile navbar
> > menu (maybe absolute position?)
> > 
> > (You can deal with this separately if you want)
> 
> You may be referring to the content on the homepage. This is a separate case.
> The start of the logo and the end of the menu icon align with the start and
end
> of content in other pages on mobile devices. I chose to use padding within the
> logo and menu icon instead of margin around them so that their active/focus
> states (which are visually distinguished) include that space before/after
them.

Ack. I was referring to homepage.

[juliandoucette, 2017-10-30 12:03:48]

https://bitbucket.org/adblockplus/adblockplus.org/commits/6e013a78a8f69351d06...