Issue 5651 - Set relative values for strong and small elements

Issue 5651 - Set relative values for strong and small elements

[ire, 2017-10-26 10:11:08]

Thanks Julian! 2 comments

https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_reset....
File static/scss/_reset.scss (right):

https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_reset....
static/scss/_reset.scss:146: font-size: 80%;
Apparently the keyword `smaller` is a thing
https://developer.mozilla.org/en-US/docs/Web/CSS/font-size

https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_variab...
File static/scss/_variables.scss (left):

https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_variab...
static/scss/_variables.scss:63: $large-font: 1.2em !default;
I don't know that we necessarily want to remove these? Although I don't think
they are currently being used, I think they could still be relevant. Or at least
we should handle/discuss removing them in a separate issue

https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_variab...
static/scss/_variables.scss:63: $large-font: 1.2em !default;
Actually I'm not sure about this comment anymore. If we are not currently using
any of these values on any site it makes sense to remove them

[juliandoucette, 2017-10-26 11:25:50]

Done.

https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_reset....
File static/scss/_reset.scss (right):

https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_reset....
static/scss/_reset.scss:146: font-size: 80%;
On 2017/10/26 10:11:08, ire wrote:
> Apparently the keyword `smaller` is a thing
> https://developer.mozilla.org/en-US/docs/Web/CSS/font-size

Awesome! I didn't know! :)

https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_variab...
File static/scss/_variables.scss (left):

https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_variab...
static/scss/_variables.scss:63: $large-font: 1.2em !default;
On 2017/10/26 10:11:08, ire wrote:
> Actually I'm not sure about this comment anymore. If we are not currently
using
> any of these values on any site it makes sense to remove them

I forgot to explain (sorry). But you figured it out. I removed these because
they are not being used and I don't know when they will be. I think we should
try our best not to bloat this ~library. Add only what we need when we need it
and use it everywhere. That way we can be more consistent / maintain less.

[ire, 2017-10-26 12:45:27]

LGTM

https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_reset....
File static/scss/_reset.scss (right):

https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_reset....
static/scss/_reset.scss:146: font-size: 80%;
On 2017/10/26 11:25:50, juliandoucette wrote:
> On 2017/10/26 10:11:08, ire wrote:
> > Apparently the keyword `smaller` is a thing
> > https://developer.mozilla.org/en-US/docs/Web/CSS/font-size
> 
> Awesome! I didn't know! :)

Me neither!

https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_variab...
File static/scss/_variables.scss (left):

https://codereview.adblockplus.org/29588979/diff/29588980/static/scss/_variab...
static/scss/_variables.scss:63: $large-font: 1.2em !default;
On 2017/10/26 11:25:50, juliandoucette wrote:
> On 2017/10/26 10:11:08, ire wrote:
> > Actually I'm not sure about this comment anymore. If we are not currently
> using
> > any of these values on any site it makes sense to remove them
> 
> I forgot to explain (sorry). But you figured it out. I removed these because
> they are not being used and I don't know when they will be. I think we should
> try our best not to bloat this ~library. Add only what we need when we need it
> and use it everywhere. That way we can be more consistent / maintain less.

I totally agree :)

[juliandoucette, 2017-10-26 15:00:18]

https://hg.adblockplus.org/website-defaults/rev/34226f3c319a