Issue 5636 - Changed navbar contents

Issue 5636 - Changed navbar contents

[ire, 2017-10-27 12:47:27]

One comment.

https://codereview.adblockplus.org/29589609/diff/29589610/templates/default.tmpl
File templates/default.tmpl (right):

https://codereview.adblockplus.org/29589609/diff/29589610/templates/default.t...
templates/default.tmpl:96: {% for pagename in ["contribute", "about"] %}
In the spec, the order is ["about", "contribute"]

[juliandoucette, 2017-10-28 11:35:16]

@Jeen please find a question below.

https://codereview.adblockplus.org/29589609/diff/29589610/templates/default.tmpl
File templates/default.tmpl (right):

https://codereview.adblockplus.org/29589609/diff/29589610/templates/default.t...
templates/default.tmpl:96: {% for pagename in ["contribute", "about"] %}
On 2017/10/27 12:47:27, ire wrote:
> In the spec, the order is ["about", "contribute"]

See
https://bitbucket.org/adblockplus/spec/pull-requests/76/added-abp-website-spe...

We are supposed to go by what the spec says not what the screenshots show. That
being said, I'm not sure that the spec is right :D

Can you please confirm Jeen?

[jeen, 2017-10-30 10:29:46]

On 2017/10/28 11:35:16, juliandoucette wrote:
> @Jeen please find a question below.
> 
>
https://codereview.adblockplus.org/29589609/diff/29589610/templates/default.tmpl
> File templates/default.tmpl (right):
> 
>
https://codereview.adblockplus.org/29589609/diff/29589610/templates/default.t...
> templates/default.tmpl:96: {% for pagename in ["contribute", "about"] %}
> On 2017/10/27 12:47:27, ire wrote:
> > In the spec, the order is ["about", "contribute"]
> 
> See
>
https://bitbucket.org/adblockplus/spec/pull-requests/76/added-abp-website-spe...
> 
> We are supposed to go by what the spec says not what the screenshots show.
That
> being said, I'm not sure that the spec is right :D
> 
> Can you please confirm Jeen?

Yes the order should be: 'About' then 'Contribute' - let me update the text in
the spec to reflect this. Thanks!

[juliandoucette, 2017-10-30 12:08:06]

On 2017/10/30 10:29:46, jeen wrote:
> Yes the order should be: 'About' then 'Contribute' - let me update the text in
> the spec to reflect this. Thanks!

Thanks! Done.

[ire, 2017-10-31 07:48:29]

LGTM

[juliandoucette, 2017-11-22 15:44:26]

@Jeen

This is currently blocked by:
https://bitbucket.org/adblockplus/spec/pull-requests/76/added-abp-website-spe...

[juliandoucette, 2017-11-22 15:46:01]

@Jeen

I'd also like to address
https://bitbucket.org/adblockplus/spec/pull-requests/76/added-abp-website-spe...
too if it doesn't delay publishing too much.

(The suggestion about using the i18n icon)

[juliandoucette, 2017-11-27 17:34:11]

On 2017/11/22 15:46:01, juliandoucette wrote:
> @Jeen
> 
> I'd also like to address
>
https://bitbucket.org/adblockplus/spec/pull-requests/76/added-abp-website-spe...
> too if it doesn't delay publishing too much.
> 
> (The suggestion about using the i18n icon)

The globe icon was decided on in the spec.

@Jeen The locale text didn't look right to me with the globe icon and the locale
code. As a result, I removed the locale codes in the latest PatchSet. I don't
think that this code adds any not-stylistic value? Anyway, if you disagree,
would you mind having a look at the [globe, text, code] combination and letting
me know if you think it's okay already or if you want to adjust it a bit?

[jeen, 2017-11-28 15:11:59]

On 2017/11/27 17:34:11, juliandoucette wrote:
> On 2017/11/22 15:46:01, juliandoucette wrote:
> > @Jeen
> > 
> > I'd also like to address
> >
>
https://bitbucket.org/adblockplus/spec/pull-requests/76/added-abp-website-spe...
> > too if it doesn't delay publishing too much.
> > 
> > (The suggestion about using the i18n icon)
> 
> The globe icon was decided on in the spec.
> 
> @Jeen The locale text didn't look right to me with the globe icon and the
locale
> code. As a result, I removed the locale codes in the latest PatchSet. I don't
> think that this code adds any not-stylistic value? Anyway, if you disagree,
> would you mind having a look at the [globe, text, code] combination and
letting
> me know if you think it's okay already or if you want to adjust it a bit?

I'm happy with removing the locale codes.