Unified Diff: include.preload.js
Issue 29589668:
Issue 5938 - Use top-level var for global variables (Closed)
Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set:
Created Oct. 26, 2017, 8:44 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« composer.postload.js ('K')
|
« ext/common.js ('k')
|
polyfill.js » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: include.preload.js |
| =================================================================== |
| --- a/include.preload.js |
| +++ b/include.preload.js |
| @@ -518,13 +518,8 @@ |
| document.addEventListener("load", event => |
| { |
| let element = event.target; |
| if (/^i?frame$/.test(element.localName)) |
| checkCollapse(element); |
| }, true); |
| } |
| - |
| -window.checkCollapse = checkCollapse; |
|
Manish Jethani
2017/10/26 20:47:56
This didn't really make sense, the variables are a
kzar
2017/10/27 11:17:40
Have you tested that? include.preload.js in the bu
Manish Jethani
2017/10/27 11:40:08
I see, you're right, it doesn't actually work, and
|
| -window.elemhide = elemhide; |
| -window.typeMap = typeMap; |
| -window.getURLsFromElement = getURLsFromElement; |
« composer.postload.js ('K')
|
« ext/common.js ('k')
|
polyfill.js » ('j')
|
no next file with comments »
