Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(138)

Issue 29589674: Issue 5942 - don't create Gecko update manifests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by tlucas
Modified:
1 year, 11 months ago
CC:
Jon Sonesen
Visibility:
Public.

Description

Issue 5942 - don't create Gecko update manifests Repository: sitescripts base: 6eca5c4c3944

Patch Set 1 #

Patch Set 2 : Removing further unused code #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -107 lines) Patch
M .sitescripts.example View 2 chunks +0 lines, -2 lines 0 comments Download
M sitescripts/extensions/bin/createNightlies.py View 1 3 chunks +1 line, -17 lines 2 comments Download
M sitescripts/extensions/bin/updateUpdateManifests.py View 3 chunks +1 line, -14 lines 0 comments Download
D sitescripts/extensions/template/updates.json View 1 chunk +0 lines, -31 lines 0 comments Download
D sitescripts/extensions/test/oracle/updates.json View 1 chunk +0 lines, -40 lines 0 comments Download
M sitescripts/extensions/test/sitescripts.ini.template View 1 chunk +0 lines, -2 lines 0 comments Download
M sitescripts/extensions/test/test_updateManifests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
tlucas
Hi everyone. This get's rid of the now redundant creation of update manifests and all ...
1 year, 11 months ago (2017-10-26 20:49:46 UTC) #1
Vasily Kuznetsov
It looks good to me although someone who better understands the logic should also have ...
1 year, 11 months ago (2017-10-27 18:47:05 UTC) #2
tlucas
Hey Vasily, there actually is some more code that can be removed (if i'm not ...
1 year, 11 months ago (2017-10-27 19:14:48 UTC) #3
Vasily Kuznetsov
1 year, 11 months ago (2017-11-07 17:49:21 UTC) #4
Then LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5