Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: sitescripts/extensions/bin/updateUpdateManifests.py

Issue 29589674: Issue 5942 - don't create Gecko update manifests (Closed)
Patch Set: Removing further unused code Created Oct. 26, 2017, 10:35 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sitescripts/extensions/bin/updateUpdateManifests.py
diff --git a/sitescripts/extensions/bin/updateUpdateManifests.py b/sitescripts/extensions/bin/updateUpdateManifests.py
index 5555228cdb46c008bbb2faaedbd66c44b22f4bfe..aa12d48129112b9cebda4169681715d0765971db 100644
--- a/sitescripts/extensions/bin/updateUpdateManifests.py
+++ b/sitescripts/extensions/bin/updateUpdateManifests.py
@@ -27,7 +27,6 @@ import subprocess
import xml.dom.minidom as dom
from ConfigParser import SafeConfigParser
-from buildtools.packagerGecko import KNOWN_APPS
from buildtools.packagerSafari import get_developer_identifier
from buildtools.xarfile import read_certificates_and_key
@@ -71,18 +70,6 @@ def readMetadata(repo, version):
'basename': metadata.get('general', 'basename'),
'updatedFromGallery': True
}
- elif repo.type == 'gecko':
- metadata = repo.readMetadata(version)
- result = {
- 'extensionID': metadata.get('general', 'id'),
- 'version': version,
- 'compat': []
- }
- for key, value in KNOWN_APPS.iteritems():
- if metadata.has_option('compat', key):
- minVersion, maxVersion = metadata.get('compat', key).split('/')
- result['compat'].append({'id': value, 'minVersion': minVersion, 'maxVersion': maxVersion})
- return result
elif repo.type == 'ie':
return {
'version': version,
@@ -97,7 +84,7 @@ def writeUpdateManifest(links):
writes an update manifest for all extensions and Android apps
"""
- extensions = {'gecko': [], 'android': [], 'safari': [], 'ie': []}
+ extensions = {'android': [], 'safari': [], 'ie': []}
for repo in Configuration.getRepositoryConfigurations():
if repo.type not in extensions or not links.has_section(repo.repositoryName):
continue

Powered by Google App Engine
This is Rietveld