Issue 29590583: Noissue - Applied responsive margin & padding mixins

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29590583: Noissue - Applied responsive margin & padding mixins (Closed)

Created:
Oct. 27, 2017, 12:15 p.m. by juliandoucette

Modified:
Oct. 29, 2017, 1:05 p.m.

Reviewers:
ire

Base URL:
https://hg.adblockplus.org/website-defaults

Visibility:
Public.

Patch Set 2 : Changed grid breakpoint and removed package-lock.json #

Total comments: 3

Created: Oct. 27, 2017, 12:21 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -4 lines)			Patch
M	static/scss/_grid.scss	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A	static/scss/_mixins.scss	View		1 chunk	+113 lines, -0 lines	3 comments	Download
M	static/scss/_utilities.scss	View		1 chunk	+11 lines, -2 lines	0 comments	Download
M	static/scss/_variables.scss	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
M	static/scss/main.scss	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

juliandoucette

Wasn't sure if/how I wanted to do this. Please ignore package-lock.json and let me know ...

Oct. 27, 2017, 12:16 p.m. (2017-10-27 12:16:29 UTC) #2

juliandoucette

Added notes. https://codereview.adblockplus.org/29590583/diff/29590591/static/scss/_mixins.scss File static/scss/_mixins.scss (right): https://codereview.adblockplus.org/29590583/diff/29590591/static/scss/_mixins.scss#newcode17 static/scss/_mixins.scss:17: @mixin padding-x($padding, $multiplier: 1) Note: The multiplier ...

Oct. 27, 2017, 1:40 p.m. (2017-10-27 13:40:02 UTC) #3

juliandoucette

Oct. 29, 2017, 1:05 p.m. (2017-10-29 13:05:21 UTC) #4

Message was sent while issue was closed.

Scratch this. I'll refactor separately if necessary.

Expand All Messages | Collapse All Messages