Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29590629: Issue 5956 - Catch exception when enumerating stylesheets (Closed)

Created:
Oct. 27, 2017, 11:27 p.m. by hub
Modified:
Nov. 3, 2017, 1:34 p.m.
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 5956 - Catch exception when enumerating stylesheets

Patch Set 1 #

Patch Set 2 : Catch the exceptions inside too #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -14 lines) Patch
M lib/content/elemHideEmulation.js View 1 1 chunk +30 lines, -14 lines 3 comments Download

Messages

Total messages: 6
hub
Oct. 27, 2017, 11:27 p.m. (2017-10-27 23:27:15 UTC) #1
hub
Until the actually reason why the exception is thrown is identified (and fixed) this allow ...
Oct. 27, 2017, 11:28 p.m. (2017-10-27 23:28:09 UTC) #2
Wladimir Palant
According to some articles on the web, this error might be thrown on stylesheets that ...
Oct. 28, 2017, 7:09 p.m. (2017-10-28 19:09:51 UTC) #3
hub
In some situation (the one I encountered when analyzing the problem) the exception occur on ...
Oct. 30, 2017, 7:33 p.m. (2017-10-30 19:33:34 UTC) #4
kzar
https://codereview.adblockplus.org/29590629/diff/29592646/lib/content/elemHideEmulation.js File lib/content/elemHideEmulation.js (right): https://codereview.adblockplus.org/29590629/diff/29592646/lib/content/elemHideEmulation.js#newcode420 lib/content/elemHideEmulation.js:420: // Explicitly ignore third-party stylesheets to ensure consistent behavior ...
Nov. 3, 2017, 10:20 a.m. (2017-11-03 10:20:51 UTC) #5
Wladimir Palant
Nov. 3, 2017, 10:46 a.m. (2017-11-03 10:46:43 UTC) #6
I uploaded an alternative fix in https://codereview.adblockplus.org/29596576/
which seems to address the root cause here.

Powered by Google App Engine
This is Rietveld