Issue 5941 - Implemented background-color utility classes

Issue 5941 - Implemented background-color utility classes

[juliandoucette, 2017-10-29 13:42:09]

Note: The rest of our utility classes are missing demos. I think we should
address this separately. I also think that we should consider separating some of
our utilities into separate files so that they can be excluded from some
websites e.g. if there are no forms then there may be no need for a .bg-error.

Note: I didn't address background-images because I am not yet convinced that we
have the same background-image style in several sections of several of our
websites. I will address images separately later if necessary.

[ire, 2017-10-30 08:16:20]

On 2017/10/29 13:42:09, juliandoucette wrote:
> Note: The rest of our utility classes are missing demos. I think we should
> address this separately. I also think that we should consider separating some
of
> our utilities into separate files so that they can be excluded from some
> websites e.g. if there are no forms then there may be no need for a .bg-error.

Yes I agree.

> Note: I didn't address background-images because I am not yet convinced that
we
> have the same background-image style in several sections of several of our
> websites. I will address images separately later if necessary.

Agreed. I haven't yet seen a consistent enough background-image style to warrant
a utility class

[ire, 2017-10-30 08:16:28]

LGTM

[juliandoucette, 2017-10-30 13:01:54]

https://hg.adblockplus.org/website-defaults/rev/1cd3b345f2ff