Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: updates.html

Issue 29592569: Issue 5943 - Implement Updates Page for Adblock Plus extension (Closed) Base URL: https://hg.adblockplus.org/adblockplusui/
Patch Set: Addressed fifth round of feedback Created Dec. 5, 2017, 2:36 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: updates.html
===================================================================
new file mode 100644
--- /dev/null
+++ b/updates.html
@@ -0,0 +1,97 @@
+<!DOCTYPE html>
+<!--
+ - This file is part of Adblock Plus <https://adblockplus.org/>,
+ - Copyright (C) 2006-present eyeo GmbH
+ -
+ - Adblock Plus is free software: you can redistribute it and/or modify
+ - it under the terms of the GNU General Public License version 3 as
+ - published by the Free Software Foundation.
+ -
+ - Adblock Plus is distributed in the hope that it will be useful,
+ - but WITHOUT ANY WARRANTY; without even the implied warranty of
+ - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ - GNU General Public License for more details.
+ -
+ - You should have received a copy of the GNU General Public License
+ - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
+ -->
+
+<html>
+ <head>
+ <title class="i18n_updates_status"></title>
+ <meta charset="utf-8" />
+ <meta name="viewport" content="width=device-width, initial-scale=1" />
+ <link href="skin/updates.css" rel="stylesheet"/>
+ <script src="polyfill.js"></script>
+ <script src="ext/common.js"></script>
+ <script src="ext/content.js"></script>
+ <script src="common.js"></script>
+ <script src="i18n.js"></script>
+ <script src="updates.js"></script>
+ </head>
+
+ <body>
+
+ <main>
+ <div id="container">
+
+ <header class="column graphic-column">
+ <div class="update-graphic-container">
+ <div class="update-graphic-content">
+ <img src="/skin/abp-logo.svg"/>
+ <div class="version-details">
+ <h2 class="i18n_updates_status"></h2>
+ </div>
+
+ </div>
+ </header>
+
+ <section class="column content-column">
+
+ <div id="content">
+
+ <header>
+ <h1 class="i18n_updates_heading"></h1>
+ <p class="i18n_updates_subheading"></p>
+ </header>
+
+ <article class="feature-entry">
+ <img class="feature-icon" src="/skin/updates/icon-rocket.svg" alt="rocket-icon"/>
+ <p id="options-page-news" class="i18n_updates_optionsPageNews"></p>
+ </article>
+
+ <article class="feature-entry">
+ <img class="feature-icon" src="/skin/updates/icon-thumbs-up.svg" alt="thumbs-up-icon"/>
Thomas Greiner 2018/01/10 12:28:21 Detail: Please remove the alt-text from all three
martin 2018/01/12 11:15:41 Done.
+ <p id="block-ads-text" class="i18n_updates_blockAds"></p>
+ </article>
+
+ <article class="custom-feature-entry">
+ <h2 class="i18n_updates_phone"></h2>
+
+ <div class="feature-entry">
+ <img class="feature-icon" src="/skin/updates/icon-mobile.svg" alt="thumbs-up-icon"/>
+ <p id="adblock-browser-text" class="i18n_updates_adblockBrowser"></p>
+ </div>
+
+ <div class="store-buttons">
+ <a id="adblock_browser_ios_store" class="store-button applestore-button" target="_blank">
Thomas Greiner 2017/12/11 12:11:10 Coding style: "Separate words in ID and class name
martin 2017/12/14 11:25:16 Can I change the `adblock_browser_ios_store` ID? I
Thomas Greiner 2017/12/14 13:36:26 In the JavaScript file you're retrieving the URL f
martin 2017/12/19 12:59:51 Done.
martin 2018/01/12 11:15:41 Done.
+ <img src="skin/updates/appstore-bg.svg" alt="apple store button">
+ </a>
+ <a id="adblock_browser_android_store" class="store-button googleplay-button" target="_blank">
+ <img src="skin/updates/googleplay-bg.svg" alt="google play store button">
+ </a>
+ </div>
+
+ </article>
+
+ </div>
+
+ </section>
+
+ </div>
+
+ </main>
+
+ </body>
+
+ </html>

Powered by Google App Engine
This is Rietveld