Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29592604: Issue 5957 - Get the unit tests passing again (Closed)

Created:
Oct. 30, 2017, 2:53 p.m. by kzar
Modified:
Oct. 30, 2017, 10:30 p.m.
Reviewers:
Manish Jethani
CC:
Sebastian Noack, Wladimir Palant
Visibility:
Public.

Description

Issue 5957 - Get the unit tests passing again

Patch Set 1 #

Patch Set 2 : lib/adblockplus.js isn't required for the tests anymore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -126 lines) Patch
M metadata.chrome View 1 2 chunks +7 lines, -7 lines 0 comments Download
M qunit/tests/cssEscaping.js View 1 chunk +1 line, -1 line 0 comments Download
M qunit/tests/filterValidation.js View 1 chunk +1 line, -1 line 0 comments Download
M qunit/tests/prefs.js View 1 chunk +1 line, -1 line 0 comments Download
M qunit/tests/url.js View 1 chunk +1 line, -1 line 0 comments Download
D qunit/tests/versionComparator.js View 1 chunk +0 lines, -115 lines 0 comments Download

Messages

Total messages: 3
kzar
Patch Set 1
Oct. 30, 2017, 2:55 p.m. (2017-10-30 14:55:18 UTC) #1
kzar
Patch Set 2 : lib/adblockplus.js isn't required for the tests anymore
Oct. 30, 2017, 3:18 p.m. (2017-10-30 15:18:08 UTC) #2
Manish Jethani
Oct. 30, 2017, 5:59 p.m. (2017-10-30 17:59:52 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld