Issue 29592630: Issue 5734 - Add utility classes to website-defaults

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29592630: Issue 5734 - Add utility classes to website-defaults (Closed)

Created:
Oct. 30, 2017, 4:18 p.m. by ire

Modified:
Oct. 31, 2017, 1:57 p.m.

Reviewers:
juliandoucette

Base URL:
https://hg.adblockplus.org/website-defaults

Visibility:
Public.

Description

Issue 5734 - Add utility classes to website-defaults

Patch Set 1 #

Total comments: 1

Created: Oct. 30, 2017, 4:18 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -0 lines)			Patch
	M	pages/utilities.html	View		1 chunk	+14 lines, -0 lines	0 comments	Download
	M	static/scss/_utilities.scss	View		1 chunk	+26 lines, -0 lines	1 comment	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

ire

https://codereview.adblockplus.org/29592630/diff/29592631/static/scss/_utilities.scss File static/scss/_utilities.scss (right): https://codereview.adblockplus.org/29592630/diff/29592631/static/scss/_utilities.scss#newcode55 static/scss/_utilities.scss:55: /* Text alignment I don't know if we need/want ...

Oct. 30, 2017, 4:19 p.m. (2017-10-30 16:19:56 UTC) #2

juliandoucette

RE: Do we need all this? Let's separate these (and others) separately.

Oct. 31, 2017, 12:08 p.m. (2017-10-31 12:08:52 UTC) #4

ire

On 2017/10/31 12:08:52, juliandoucette wrote: > RE: Do we need all this? > > Let's ...

Oct. 31, 2017, 12:16 p.m. (2017-10-31 12:16:29 UTC) #5

juliandoucette

On 2017/10/31 12:16:29, ire wrote: > On 2017/10/31 12:08:52, juliandoucette wrote: > > RE: Do ...

Oct. 31, 2017, 1:41 p.m. (2017-10-31 13:41:30 UTC) #6

ire

Oct. 31, 2017, 1:56 p.m. (2017-10-31 13:56:58 UTC) #7

On 2017/10/31 13:41:30, juliandoucette wrote:
> On 2017/10/31 12:16:29, ire wrote:
> > On 2017/10/31 12:08:52, juliandoucette wrote:
> > > RE: Do we need all this?
> > > 
> > > Let's separate these (and others) separately.
> > 
> > TBC (to be clear) I should exclude all the text alignment classes from this
> > commit?
> 
> No, sorry. I meant that you can commit everything and we can decide how to
> separate anything that we think we should separately later.

Okay thanks

Expand All Messages | Collapse All Messages