Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29593555: Noissue - Remove overriding padding on #site-footer .column (Closed)

Created:
Oct. 31, 2017, 8:13 a.m. by ire
Modified:
Nov. 1, 2017, 7:46 a.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/help.eyeo.com
Visibility:
Public.

Description

Remove overriding padding on #site-footer .column

Patch Set 1 #

Patch Set 2 : Remove overriding padding on #site-footer .column #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M static/scss/layout/_footer.scss View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5
ire
Oct. 31, 2017, 8:13 a.m. (2017-10-31 08:13:44 UTC) #1
ire
The negative margins on the .row was removing the horizontal padding on the footer
Oct. 31, 2017, 8:14 a.m. (2017-10-31 08:14:10 UTC) #2
juliandoucette
[this](https://hg.adblockplus.org/help.eyeo.com/file/tip/static/scss/layout/_footer.scss#l24) is removing the padding from the columns. Why not remove it instead?
Oct. 31, 2017, 12:42 p.m. (2017-10-31 12:42:32 UTC) #3
ire
On 2017/10/31 12:42:32, juliandoucette wrote: > [this](https://hg.adblockplus.org/help.eyeo.com/file/tip/static/scss/layout/_footer.scss#l24) > is removing the padding from the columns. ...
Oct. 31, 2017, 2:12 p.m. (2017-10-31 14:12:00 UTC) #4
juliandoucette
Oct. 31, 2017, 2:15 p.m. (2017-10-31 14:15:16 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld