Issue 29595588: Issue 5952 - Clicking Cancel in the issue reporter doesn't close the tab

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29595588: Issue 5952 - Clicking Cancel in the issue reporter doesn't close the tab (Closed)

Created:
Nov. 2, 2017, 11:39 a.m. by Wladimir Palant

Modified:
Nov. 2, 2017, 6:47 p.m.

Reviewers:
Thomas Greiner

CC:
kzar

Base URL:
https://hg.adblockplus.org/adblockplusui/

Visibility:
Public.

Description

Issue 5952 - Clicking Cancel in the issue reporter doesn't close the tab

Patch Set 1 #

Total comments: 3

Created: Nov. 2, 2017, 11:39 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
	M	issue-reporter.js	View		4 chunks	+11 lines, -3 lines	3 comments	Download
	M	messageResponder.js	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Thomas Greiner

https://codereview.adblockplus.org/29595588/diff/29595589/issue-reporter.js File issue-reporter.js (right): https://codereview.adblockplus.org/29595588/diff/29595589/issue-reporter.js#newcode71 issue-reporter.js:71: }).then(tabId => browser.tabs.remove(tabId)); Wouldn't it make more sense to ...

Nov. 2, 2017, 12:39 p.m. (2017-11-02 12:39:51 UTC) #2

Wladimir Palant

Nov. 2, 2017, 1:16 p.m. (2017-11-02 13:16:51 UTC) #3

Thomas Greiner

Nov. 2, 2017, 2:13 p.m. (2017-11-02 14:13:02 UTC) #4

I'm fine with either approach so LGTM for this one.

https://codereview.adblockplus.org/29595588/diff/29595589/issue-reporter.js
File issue-reporter.js (right):

https://codereview.adblockplus.org/29595588/diff/29595589/issue-reporter.js#n...
issue-reporter.js:71: }).then(tabId => browser.tabs.remove(tabId));
On 2017/11/02 13:16:51, Wladimir Palant wrote:
> On 2017/11/02 12:39:51, Thomas Greiner wrote:
> > Wouldn't it make more sense to leave it up to the background page to close
the
> > tab (e.g. "app.close") if we're already communicating with it anyway? That
way
> > we wouldn't need to deal with implementation details in the UI.
> 
> That's the approach I chose initially but so far we don't have any browser API
> calls in messageResponder. It seems that leaving implementation details out of
> messageResponder is intentional (makes testing easier).

Not sure either whether this choice was made intentionally. Anyway, no
objections with this approach for now.

Expand All Messages | Collapse All Messages