Issue 5967 - Don't rely on URLSearchParams() constructor to accept a sequence

issue-reporter.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 385 matching lines @@
   for (let i = 0; i < uuid.length; i++)
   {
     let component = uuid[i].toString(16);
     while (component.length < 4)
       component = "0" + component;
     uuidString += component;
     if (i >= 1 && i <= 4)
       uuidString += "-";
   }
 
+  // Passing a sequence to URLSearchParams() constructor only works starting
+  // with Firefox 53, add values "manually" for now.
   let params = new URLSearchParams();
   for (let [param, value] of [

[kzar, 2017/11/03 10:12:02]

I can't remember, does array parameter destructuring work with Chrome 49?

[kzar, 2017/11/03 10:12:03]

Maybe add a comment explaining this is a workaround for older versions of Chrome
and Firefox?

[Wladimir Palant, 2017/11/03 10:45:41]

It does. That's part of the reason why we require Chrome 49.
Done.

     ["version", 1],
     ["guid", uuidString],
     ["lang", reportData.getElementsByTagName("adblock-plus")[0]
                        .getAttribute("locale")]
   ])
   {
     params.append(param, value);
   }
 
   let url = "https://reports.adblockplus.org/submitReport?" + params;
@@ skipping 89 matching lines @@
       progress.value = event.loaded;
     }
   });
   request.send(serializeReportData());
 }
 
 function leaveSendPage()
 {
   closeMe();
 }