Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29595598: Issue 5967 - Don't rely on URLSearchParams() constructor to accept a sequence (Closed)

Created:
Nov. 2, 2017, 1:44 p.m. by Wladimir Palant
Modified:
Nov. 3, 2017, 10:51 a.m.
Reviewers:
Thomas Greiner, kzar
Base URL:
https://hg.adblockplus.org/adblockplusui/
Visibility:
Public.

Description

Issue 5967 - Don't rely on URLSearchParams() constructor to accept a sequence

Patch Set 1 #

Total comments: 3

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M issue-reporter.js View 1 1 chunk +13 lines, -6 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Nov. 2, 2017, 1:44 p.m. (2017-11-02 13:44:12 UTC) #1
kzar
https://codereview.adblockplus.org/29595598/diff/29595599/issue-reporter.js File issue-reporter.js (right): https://codereview.adblockplus.org/29595598/diff/29595599/issue-reporter.js#newcode407 issue-reporter.js:407: for (let [param, value] of [ Maybe add a ...
Nov. 3, 2017, 10:12 a.m. (2017-11-03 10:12:04 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29595598/diff/29595599/issue-reporter.js File issue-reporter.js (right): https://codereview.adblockplus.org/29595598/diff/29595599/issue-reporter.js#newcode407 issue-reporter.js:407: for (let [param, value] of [ On 2017/11/03 10:12:02, ...
Nov. 3, 2017, 10:45 a.m. (2017-11-03 10:45:41 UTC) #3
kzar
Nov. 3, 2017, 10:50 a.m. (2017-11-03 10:50:36 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld