Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: compiled/ElemHide.cpp

Issue 29595633: Issue 5870 - Implement the new ElemHideEmulation filter type (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Added missing ABP_NS macros Created Feb. 9, 2018, 8:34 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiled/String.h » ('j') | compiled/filter/ElemHideBase.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiled/ElemHide.cpp
===================================================================
--- a/compiled/ElemHide.cpp
+++ b/compiled/ElemHide.cpp
@@ -192,22 +192,22 @@
}
}
return intrusive_ptr<ElemHide_SelectorList>(mUnconditionalSelectorsCache).release();
}
ElemHide_SelectorList* ElemHide::GetSelectorsForDomain(const String& domain,
Criteria criteria) const
{
- intrusive_ptr<ElemHide_SelectorList> selectors(new ElemHide_SelectorList());
+ intrusive_ptr<ElemHide_SelectorList> selectors(new ElemHide_SelectorList(), false);
sergei 2018/02/12 12:53:18 Good catch, it seems unrelated change, could you p
hub 2018/02/12 18:14:38 Done. https://codereview.adblockplus.org/29695575
annotate_address(selectors.get(), "ElemHide_SelectorList");
if (criteria < NO_UNCONDITIONAL)
{
- intrusive_ptr<ElemHide_SelectorList> selector(GetUnconditionalSelectors());
+ intrusive_ptr<ElemHide_SelectorList> selector(GetUnconditionalSelectors(), false);
selectors->append(*selector);
}
bool specificOnly = criteria >= SPECIFIC_ONLY;
StringSet seenFilters;
DependentString docDomain(domain);
DependentString currentDomain(domain);
« no previous file with comments | « no previous file | compiled/String.h » ('j') | compiled/filter/ElemHideBase.h » ('J')

Powered by Google App Engine
This is Rietveld