Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29596617: Issue 5982 - Update adblockplusui dependency to revision 17972505c6b4 (Closed)

Created:
Nov. 3, 2017, 11:03 a.m. by Wladimir Palant
Modified:
Nov. 3, 2017, 11:26 a.m.
Reviewers:
kzar
CC:
Sebastian Noack, saroyanm
Base URL:
https://hg.adblockplus.org/adblockpluschrome
Visibility:
Public.

Description

Issue 5982 - Update adblockplusui dependency to revision 17972505c6b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M dependencies View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Nov. 3, 2017, 11:03 a.m. (2017-11-03 11:03:50 UTC) #1
kzar
I know Manvel was hoping to update some strings still (#5955), perhaps we should update ...
Nov. 3, 2017, 11:23 a.m. (2017-11-03 11:23:01 UTC) #2
Wladimir Palant
I think that there will be at least one more dependency update, we have a ...
Nov. 3, 2017, 11:24 a.m. (2017-11-03 11:24:05 UTC) #3
kzar
Nov. 3, 2017, 11:26 a.m. (2017-11-03 11:26:21 UTC) #4
Message was sent while issue was closed.
On 2017/11/03 11:24:05, Wladimir Palant wrote:
> I think that there will be at least one more dependency update, we have a
bunch
> of outstanding UI issues. No reason not to test the changes we have already.

Fair enough, LGTM

Powered by Google App Engine
This is Rietveld