Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29596640: Noissue - Update dependecies and tools (Closed)

Created:
Nov. 3, 2017, 1:16 p.m. by jens
Modified:
Nov. 8, 2017, 1:31 p.m.
Reviewers:
diegocarloslima, anton
CC:
Felix Dahlke, René Jeschke
Visibility:
Public.

Description

Updated dependencies to work with Android Studio 3.0

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M adblockplussbrowser/build.gradle View 1 chunk +1 line, -1 line 1 comment Download
R adblockplussbrowser/libs/android-support-v4.jar View Binary file 0 comments Download
M build.gradle View 1 chunk +9 lines, -5 lines 0 comments Download
M gradle/wrapper/gradle-wrapper.properties View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
jens
Nov. 3, 2017, 1:26 p.m. (2017-11-03 13:26:23 UTC) #1
jens
https://codereview.adblockplus.org/29596640/diff/29596645/adblockplussbrowser/build.gradle File adblockplussbrowser/build.gradle (left): https://codereview.adblockplus.org/29596640/diff/29596645/adblockplussbrowser/build.gradle#oldcode39 adblockplussbrowser/build.gradle:39: project.tasks.prepareReleaseDependencies << { The task 'prepareReleaseDependencies ' does not ...
Nov. 3, 2017, 1:33 p.m. (2017-11-03 13:33:27 UTC) #2
anton
On 2017/11/03 13:33:27, jens wrote: > https://codereview.adblockplus.org/29596640/diff/29596645/adblockplussbrowser/build.gradle > File adblockplussbrowser/build.gradle (left): > > https://codereview.adblockplus.org/29596640/diff/29596645/adblockplussbrowser/build.gradle#oldcode39 > ...
Nov. 7, 2017, 7:05 a.m. (2017-11-07 07:05:25 UTC) #3
diegocarloslima
On 2017/11/07 07:05:25, anton wrote: > On 2017/11/03 13:33:27, jens wrote: > > > https://codereview.adblockplus.org/29596640/diff/29596645/adblockplussbrowser/build.gradle ...
Nov. 8, 2017, 11:33 a.m. (2017-11-08 11:33:55 UTC) #4
jens
Nov. 8, 2017, 1:01 p.m. (2017-11-08 13:01:56 UTC) #5
On 2017/11/07 07:05:25, anton wrote:
> On 2017/11/03 13:33:27, jens wrote:
> >
>
https://codereview.adblockplus.org/29596640/diff/29596645/adblockplussbrowser...
> > File adblockplussbrowser/build.gradle (left):
> > 
> >
>
https://codereview.adblockplus.org/29596640/diff/29596645/adblockplussbrowser...
> > adblockplussbrowser/build.gradle:39:
project.tasks.prepareReleaseDependencies
> <<
> > {
> > The task 'prepareReleaseDependencies ' does not exist anymore.
> 
> LGTM.
> 
> Just curious if you have any incompatibility issues? As for me i try to wait
for
> a month or next minor release with first issues fixed and then migrate.

No, I did not have any issues so far.

Powered by Google App Engine
This is Rietveld