Issue 29596663: Issue 5973 - broken icons on Firefox v50-53

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29596663: Issue 5973 - broken icons on Firefox v50-53 (Closed)

Created:
Nov. 3, 2017, 5:48 p.m. by saroyanm

Modified:
Nov. 3, 2017, 5:53 p.m.

Reviewers:

Visibility:
Public.

Description

Issue 5973 - broken icons on Firefox v50-53

Patch Set 1 #

Total comments: 2

Created: Nov. 3, 2017, 5:48 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -57 lines)			Patch
M	skin/desktop-options.css	View	9 chunks	+27 lines, -45 lines	0 comments	Download
M	skin/icons/attention.svg	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	skin/icons/checkmark.svg	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	skin/icons/code.svg	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	skin/icons/delete.svg	View	1 chunk	+13 lines, -1 line	0 comments	Download
M	skin/icons/gear.svg	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	skin/icons/globe.svg	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	skin/icons/reload.svg	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	skin/icons/tooltip.svg	View	1 chunk	+3 lines, -1 line	1 comment	Download
M	skin/icons/trash.svg	View	1 chunk	+13 lines, -1 line	1 comment	Download
M	skin/social/facebook.svg	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	skin/social/googleplus.svg	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	skin/social/twitter.svg	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

saroyanm

https://codereview.adblockplus.org/29596663/diff/29596664/skin/icons/tooltip.svg File skin/icons/tooltip.svg (right): https://codereview.adblockplus.org/29596663/diff/29596664/skin/icons/tooltip.svg#newcode2 skin/icons/tooltip.svg:2: <path d="M24,0A24,24,0,1,0,48,24,24,24,0,0,0,24,0Zm0,46A22,22,0,1,1,46,24,22,22,0,0,1,24,46Z"/><path d="M23.24,28.26a1.82,1.82,0,0,0-1.38.57,2.21,2.21,0,0,0,0,2.91,1.82,1.82,0,0,0,1.38.57,1.87,1.87,0,0,0,1.39-.57,2.17,2.17,0,0,0,0-2.91A1.87,1.87,0,0,0,23.24,28.26Z"/><path d="M26.88,15.36a4.35,4.35,0,0,0-1.53-.82,6.48,6.48,0,0,0-1.92-.27,5.21,5.21,0,0,0-2.57.64,7,7,0,0,0-2,1.63l1.66,1.53a4.93,4.93,0,0,1,1.22-1,2.93,2.93,0,0,1,1.46-.36,2,2,0,0,1,2.11,2.08A2.29,2.29,0,0,1,25,19.91,7.33,7.33,0,0,1,24.32,21q-.43.53-.91,1.09a8,8,0,0,0-.86,1.21A5.49,5.49,0,0,0,22,24.7a4.47,4.47,0,0,0-.07,1.72h2.63a3.2,3.2,0,0,1,.14-1.51,5.93,5.93,0,0,1,.65-1.27,9.44,9.44,0,0,1,.91-1.14,13.28,13.28,0,0,0,.95-1.14,6.89,6.89,0,0,0,.74-1.26,3.6,3.6,0,0,0,.3-1.5,4.65,4.65,0,0,0-.35-1.87A3.63,3.63,0,0,0,26.88,15.36Z"/> Beautify https://codereview.adblockplus.org/29596663/diff/29596664/skin/icons/trash.svg File skin/icons/trash.svg (right): ...

Nov. 3, 2017, 5:51 p.m. (2017-11-03 17:51:13 UTC) #1

saroyanm

Nov. 3, 2017, 5:53 p.m. (2017-11-03 17:53:27 UTC) #2

My comment broke Rietveld I'll upload a new review.
NOT LGTM

Expand All Messages | Collapse All Messages